Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): remove certain files from npm, closes #499 #501

Merged
merged 2 commits into from
May 19, 2020
Merged

fix(npm): remove certain files from npm, closes #499 #501

merged 2 commits into from
May 19, 2020

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented May 19, 2020 •
edited
Loading

@ghiscoding
Copy link
Collaborator Author

ghiscoding commented May 19, 2020 •
edited
Loading

@6pac did you also wanted to add .exe and .pdb to the .gitignore as well?

EDIT

I added them to .gitignore as well, we shouldn't have any .exe anyway in the GitHub repo.
Seems like the last thing left before release :)

@ghiscoding ghiscoding changed the title fix(npm): remove certain files from npm fix(npm): remove certain files from npm, closes #499 May 19, 2020
@6pac
Copy link
Owner

6pac commented May 19, 2020

Ah, actually SlickGridRelease was in there, which covers those files. Still not a bad idea adding those exclusions.

@6pac 6pac merged commit 886641f into master May 19, 2020
@ghiscoding ghiscoding deleted the bugfix/cleanup-unnecessary-files branch May 19, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup some old backup files
2 participants
@ghiscoding @6pac