Skip to content

Commit

Permalink
feat(plugins): remove jQuery from ColumnPicker & GridMenu controls (#752
Browse files Browse the repository at this point in the history
)

* feat(plugins): remove jQuery from ColumnPicker & GridMenu controls

* tests: use input checked property instead of attr checked
- the previous code with `attr('checked')` was jQuery oriented and we are going away from jQuery
  • Loading branch information
ghiscoding committed Jul 8, 2023
1 parent 737ffd1 commit e2ac29e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions controls/slick.columnpicker.js
Original file line number Diff line number Diff line change
Expand Up @@ -301,13 +301,13 @@
col.hidden = false;
visibleColumns.splice(idx, 0, col);
} else {
let newVisibleColumns = [];
let newVisibleColumns = [];
for (let i = 0; i < visibleColumns.length; i++) {
if (visibleColumns[i].id !== col.id) { newVisibleColumns.push(visibleColumns[i]); }
}
visibleColumns = newVisibleColumns;
}

_grid.setColumns(visibleColumns);
onColumnsChanged.notify({ columnId: col.id, showing: show, allColumns: columns, columns: visibleColumns, grid: _grid });
}
Expand Down

0 comments on commit e2ac29e

Please sign in to comment.