Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module path should be "github.com/kylesliu/gin_metrics", or "github.com/kylesliu/gin-metrics " #1

Open
KateGo520 opened this issue Jul 29, 2020 · 1 comment

Comments

@KateGo520
Copy link

Background

Module path is inconsistent with go import path.
GO111MODULE=on, as README said, run go get github.com/kylesliu/gin_metrics:

go: downloading github.com/kylesliu/gin_metrics v0.0.8
go: github.com/kylesliu/gin_metrics upgrade => v0.0.8
go get: github.com/kylesliu/[email protected]: parsing go.mod:
        module declares its path as: github.com/kylesliu/gin-metrics
                but was required as: github.com/kylesliu/gin_metrics 

Solution

Fix the module path:

  1. Rename the module path to "github.com/kylesliu/gin_metrics": https://github.com/kylesliu/metrics/blob/master/go.mod#L1
module github.com/kylesliu/gin_metrics
go 1.12
require (
	…
) 
  1. Change the README document to use go get github.com/kylesliu/gin-metrics.
@KateGo520
Copy link
Author

@kylesliu Could you help me review this issue? Thx :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant