Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🗑️ Redirect deprecated /api requests to /api/2014 #672

Merged
merged 8 commits into from
Feb 22, 2025

Conversation

fergcb
Copy link
Member

@fergcb fergcb commented Feb 20, 2025

What does this do?

Adds a permanent redirect (HTTP 301) to /api/* routes, pointing to the corresponding /api/2014/* route.

How was it tested?

Manual testing in local docker container. Unit & integration tests updated to ensure 301 status code and res.redirect is called when appropriate.

Is there a Github issue this is resolving?

No.

Was any impacted documentation updated to reflect this change?

Yes. Replaced /api path in swagger.yml with /api/2014.

Here's a fun image for your troubles

A repotted plant with caption "301 Moved Permanently"

@fergcb fergcb marked this pull request as ready for review February 22, 2025 00:09
@fergcb fergcb requested a review from bagelbits February 22, 2025 00:09
@fergcb fergcb merged commit a5f4fe9 into 5e-bits:main Feb 22, 2025
10 checks passed
Copy link

🎉 This PR is included in version 3.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants