Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add 2014 version to prepare for 2024 version #636

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

bagelbits
Copy link
Collaborator

@bagelbits bagelbits commented Dec 25, 2024

What does this do?

  • Adds a 2014 version for API and for GraphQL Endpoint.
  • Swaps all models to the new 2014 tables
  • The old APIs and GraphQL endpoint are going to be deprecated and go away on 1/20

How was it tested?

Locally and with CI

Is there a Github issue this is resolving?

No

Was any impacted documentation updated to reflect this change?

Not yet. I've updated the swagger, but I still need to do the docs.

Here's a fun image for your troubles

random photo - update me

@bagelbits bagelbits changed the title feat(models): All current models are switched to the 2014- prefixed… feat(api): Add 2014 version to prepare for 2024 version Dec 25, 2024
@bagelbits bagelbits force-pushed the bagelbits.2014-versioning branch from 7ead45f to 78a3ffc Compare December 28, 2024 00:15
@bagelbits bagelbits marked this pull request as ready for review December 29, 2024 19:42
@ecshreve
Copy link
Contributor

ecshreve commented Dec 30, 2024

Should we make any updates to the README? It could probably use some love in general, but for this PR maybe a ### Versioning section under ## Making API Requests makes sense?

Or maybe we want to slim down the readme and point to the docs site for things like that?

Copy link
Contributor

@ecshreve ecshreve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These swagger changes look good to me. Tested locally

Copy link
Member

@brittonhayes brittonhayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approvin it ✅

@bagelbits bagelbits merged commit b09c32a into main Jan 6, 2025
9 checks passed
@bagelbits bagelbits deleted the bagelbits.2014-versioning branch January 6, 2025 19:30
Copy link

github-actions bot commented Jan 6, 2025

🎉 This PR is included in version 3.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants