feat: Allow serving of images from an S3 bucket #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redmega
reviewed
Oct 4, 2022
| res.status(200); | ||
| res.end('Error Fetching File'); | ||
| } else { | ||
| res.writeHead(200, { 'Content-Type': mime.lookup(params.Key) }); |
There was a problem hiding this comment.
Shouldn't you be able to get the content type from data.Headers.ContentType? Instead of relying on the extension (which is what I assume mime.lookup does)
There was a problem hiding this comment.
That's an interesting point! I'll see if I can do that.
There was a problem hiding this comment.
It ended up being data.ContentType but good catch!
Redmega
approved these changes
Oct 5, 2022
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This serves an image based on the url.
How was it tested?
Locally
Is there a Github issue this is resolving?
N/A
Was any impacted documentation updated to reflect this change?
Yes. However, I'm not sure I want to document
/api/imagesHere's a fun image for your troubles