This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[Modals redesign]Hard to read Mixtypes parameter and arrays on action review screen for safe-apps txs #3511

Open

liliya-soroka opened this issue Feb 15, 2022 · 3 comments

Labels

Member

liliya-soroka commented Feb 15, 2022

Description

Hard to read Mixtypes parameters on action review screen for safe-apps txs

Environment

Browser: Chrome
Wallet: MetaMask
Chain: Rinkeby

Steps to reproduce

Go to the safe-apps
Use Bulla banker app
check "createBullaClaim" action details

The same problem if the parameter is an array

Expected result

separate each value in the mixtypes parameter

Obtained result

No separates between the valuems

Screenshots

liliya-soroka added Bug 🐛 Minor labels

Member

katspaugh commented Mar 3, 2022

@liliiaorlenko do we have a design for this?

liliiaorlenko commented Mar 3, 2022

@liliiaorlenko do we have a design for this?

Nop, I can work on it. I will contact @liliya-soroka for details

liliiaorlenko commented Mar 9, 2022

https://www.figma.com/file/47wkjxMZkyEeCRbCrLJBJa/safe%232995-Tx-details?node-id=2362%3A22517
design based on mobile solution that currently exists

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.