-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add automatic table cleanup after go sdk tests #3799
Conversation
SDK Test Report101 files ±0 101 suites ±0 2m 5s ⏱️ -8s Results for commit eb83f3d. ± Comparison against base commit 42f9b89. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3799 +/- ##
============================================
+ Coverage 40.28% 40.31% +0.02%
Complexity 658 658
============================================
Files 194 194
Lines 11436 11436
Branches 1380 1380
============================================
+ Hits 4607 4610 +3
+ Misses 6525 6522 -3
Partials 304 304 ☔ View full report in Codecov by Sentry. |
Linux Test Report 53 files ±0 60 suites ±0 27m 58s ⏱️ -3s For more details on these failures, see this check. Results for commit eb83f3d. ± Comparison against base commit 42f9b89. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What kind of change does this PR introduce?
This PR introduces a test enhancement in the Go SDK. It adds automatic cleanup logic for database table created during tests, ensuring that tests can be rerun without the need for manual table deletion.
What is the current behavior? (You can also link to an open issue here)
Currently, the tests in the Go SDK create demo table in the database to verify various functionalities. However, it's not automatically cleaned up after the tests are completed. This behavior requires manual intervention to delete the table before tests can be rerun, leading to inefficiencies in the development process.
What is the new behavior (if this is a feature change)?
With this change, the Go SDK tests now include cleanup logic that automatically deletes demo table created during the testing process. This ensures that the database is restored to its initial state after the tests complete, allowing for tests to be rerun multiple times without manual cleanup. This improvement streamlines the testing process, making it more efficient and less error-prone.