-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support map data type in yaml testing framework #3765
Conversation
Linux Test Report 53 files 60 suites 28m 28s ⏱️ For more details on these failures, see this check. Results for commit 6121640. ♻️ This comment has been updated with latest results. |
SDK Test Report101 files ±0 101 suites ±0 2m 9s ⏱️ +2s Results for commit 6121640. ± Comparison against base commit aa803af. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
1c3a0c3
to
7a9c66b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3765 +/- ##
=========================================
Coverage 40.77% 40.77%
Complexity 658 658
=========================================
Files 195 195
Lines 11659 11659
Branches 1379 1379
=========================================
Hits 4754 4754
Misses 6601 6601
Partials 304 304 ☔ View full report in Codecov by Sentry. |
Is there performance comparison between codegen encoding and the original encoding? |
we should do some benchmark after codegen insert row generally stable (current alpha, interface may change). |
7a9c66b
to
c192b60
Compare
c192b60
to
7404dda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
allow map data type in YAML testing framework for input definition, you may define input table's schema as: columns: ["col1 int", "col2 map<int, string>"] which is exactly the same as the SQL syntax in CREATE TABLE statement. And define table values with `inputs[*].inserts`: inserts: - insert into t1 values (1, map(12, "abc")) just write down the insert statement SQL. *LIMITATIONS* - unsupported: map data type in `expect` field - INSERT statement with custom columns definition, implementation limits, each insert value expression must matches exactly to the table column definition
7404dda
to
6121640
Compare
allow map data type in YAML testing framework for input definition, you
may define input table's schema as:
columns: ["col1 int", "col2 map<int, string>"]
which is exactly the same as the SQL syntax in CREATE TABLE statement.
And define table values with
inputs[*].inserts
:inserts:
- insert into t1 values (1, map(12, "abc"))
just write down the insert statement SQL.
LIMITATIONS
expect
fieldlimits, each insert value expression must matches exactly to the table column definition