Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support const project online #3376

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Jul 18, 2023

close #2759, #3311

@github-actions github-actions bot added the execute-engine hybridse sql engine label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 86.04% and project coverage change: +0.08% 🎉

Comparison is base (fd728c6) 75.77% compared to head (c7f8f6f) 75.85%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3376      +/-   ##
============================================
+ Coverage     75.77%   75.85%   +0.08%     
  Complexity      414      414              
============================================
  Files           703      703              
  Lines        127658   127677      +19     
  Branches       1206     1206              
============================================
+ Hits          96729    96848     +119     
+ Misses        30688    30588     -100     
  Partials        241      241              
Files Changed Coverage Δ
hybridse/include/case/sql_case.h 92.10% <ø> (ø)
hybridse/include/sdk/base.h 61.22% <ø> (ø)
hybridse/include/vm/physical_op.h 91.11% <ø> (ø)
src/test/base_test.cc 0.00% <0.00%> (ø)
hybridse/src/case/sql_case.cc 70.76% <82.60%> (-0.09%) ⬇️
hybridse/src/testing/engine_test_base.h 92.26% <83.33%> (-0.33%) ⬇️
hybridse/src/case/sql_case_test.cc 100.00% <100.00%> (ø)
hybridse/src/plan/planner.cc 88.27% <100.00%> (+0.01%) ⬆️
hybridse/src/vm/runner.cc 69.57% <100.00%> (+0.31%) ⬆️
hybridse/src/vm/transform.cc 84.22% <100.00%> (+0.18%) ⬆️
... and 2 more

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd aceforeverd linked an issue Jul 19, 2023 that may be closed by this pull request
@aceforeverd
Copy link
Collaborator Author

TODO check if there is: a runner requires non-empty requests, but empty request is allow

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Aug 18, 2023
@aceforeverd
Copy link
Collaborator Author

TODO check if there is: a runner requires non-empty requests, but empty request is allow

TODO: support const project procedure. It is not fixed by this PR, since a request procedure requires a request table

@aceforeverd aceforeverd merged commit 330d171 into 4paradigm:main Sep 14, 2023
28 checks passed
dl239 pushed a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to validate SQL with db name and "SELECT 100" feat: support const project in request mode
3 participants