fix: thread races in aggregator if there are concurrent Puts
#2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
storage-engine
Codecov ReportBase: 35.89% // Head: 75.82% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2472 +/- ##
=============================================
+ Coverage 35.89% 75.82% +39.93%
- Complexity 368 371 +3
=============================================
Files 154 638 +484
Lines 9007 120084 +111077
Branches 1056 1058 +2
=============================================
+ Hits 3233 91053 +87820
- Misses 5558 28814 +23256
- Partials 216 217 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dl239
approved these changes
Sep 15, 2022
aceforeverd
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix Failed to import data with longwindow in online sever #2465
What is the current behavior? (You can also link to an open issue here)
The binlog_offset may be out-of-order to the aggregator if there are concurrent
Puts.However
aggregatorassumes it is strictly in order.What is the new behavior (if this is a feature change)?
Aggregator updateis protected bybinlog mutexand is called as a closure parameter inside binlog.This is a quick fix. A better solution will be doing asynchronous update to the aggregators from the binlog.