-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: thirdparty make glog with gflags #2452
Conversation
It's better for disabling log in sdk
Codecov ReportBase: 75.80% // Head: 75.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2452 +/- ##
============================================
- Coverage 75.80% 75.77% -0.04%
Complexity 368 368
============================================
Files 638 638
Lines 119910 119910
Branches 1056 1056
============================================
- Hits 90902 90857 -45
- Misses 28792 28837 +45
Partials 216 216
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
SDK Test Report 81 files ±0 81 suites ±0 6m 56s ⏱️ - 1m 2s Results for commit 7193a1b. ± Comparison against base commit 3ebcc7b. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
|
Closes #2200
It's better for disabling log in sdk.