Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onebox): stop_all.sh #2415

Merged
merged 1 commit into from
Aug 30, 2022
Merged

fix(onebox): stop_all.sh #2415

merged 1 commit into from
Aug 30, 2022

Conversation

aceforeverd
Copy link
Collaborator

adjust agruments to pkill (gnu vs bsd)

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

adjust agruments to pkill (gnu vs bsd)
@github-actions github-actions bot added the workflow CICD related label Aug 30, 2022
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Base: 75.91% // Head: 95.84% // Increases project coverage by +19.92% 🎉

Coverage data is based on head (a23e9b9) compared to base (b48b5bb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2415       +/-   ##
=============================================
+ Coverage     75.91%   95.84%   +19.92%     
=============================================
  Files           629        6      -623     
  Lines        119703      361   -119342     
  Branches       1044        0     -1044     
=============================================
- Hits          90878      346    -90532     
+ Misses        28609       15    -28594     
+ Partials        216        0      -216     
Impacted Files Coverage Δ
src/codec/row_codec.h
hybridse/src/plan/planner.h
...nmldb/taskmanager/udf/ExternalFunctionManager.java
...ldb/taskmanager/tracker/YarnJobTrackerThread.scala
..._4paradigm/openmldb/batch/window/RowDebugger.scala
...se/src/passes/physical/group_and_sort_optimized.cc
src/codec/sdk_codec.cc
hybridse/examples/toydb/src/sdk/tablet_sdk_test.cc
...adigm/openmldb/jdbc/CallablePreparedStatement.java
.../src/passes/physical/transform_up_physical_pass.cc
... and 613 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dl239 dl239 merged commit 618c240 into 4paradigm:main Aug 30, 2022
@aceforeverd aceforeverd deleted the fix-onebox-stop branch August 30, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants