Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openmldb-exporter): handle error during collecting metrics #2372

Merged
merged 6 commits into from
Aug 23, 2022

Conversation

aceforeverd
Copy link
Collaborator

two features:

@github-actions github-actions bot added the monitoring openmldb prometheus exporter & mixin label Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #2372 (81f2f90) into main (16a90c0) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2372      +/-   ##
============================================
+ Coverage     75.86%   75.88%   +0.02%     
  Complexity      368      368              
============================================
  Files           629      629              
  Lines        119286   119494     +208     
  Branches       1022     1036      +14     
============================================
+ Hits          90491    90683     +192     
- Misses        28579    28595      +16     
  Partials        216      216              
Impacted Files Coverage Δ
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
hybridse/src/udf/udf_test.cc 97.63% <0.00%> (-0.43%) ⬇️
src/tablet/tablet_impl.cc 61.40% <0.00%> (-0.30%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/client/tablet_client.cc 56.04% <0.00%> (-0.12%) ⬇️
hybridse/src/udf/udf.cc 85.64% <0.00%> (-0.06%) ⬇️
src/nameserver/name_server_impl.cc 42.78% <0.00%> (-0.03%) ⬇️
hybridse/src/udf/udf.h 100.00% <0.00%> (ø)
hybridse/src/planv2/ast_node_converter.cc 94.43% <0.00%> (+0.01%) ⬆️
hybridse/src/codegen/udf_ir_builder_test.cc 99.52% <0.00%> (+0.01%) ⬆️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

SDK Test Report

  79 files    79 suites   7m 3s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit 81f2f90.

@github-actions
Copy link
Contributor

Linux Test Report

       55 files       200 suites   54m 22s ⏱️
  9 754 tests   9 747 ✔️ 7 💤 0
14 355 runs  14 348 ✔️ 7 💤 0

Results for commit 81f2f90.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit b213dc8 into 4paradigm:main Aug 23, 2022
@aceforeverd aceforeverd deleted the feat-openmldb-exporter branch August 23, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring openmldb prometheus exporter & mixin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(monitoring): error handling and timeout for network requests
3 participants