Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added images for exclude_current_row in dql/window #2297

Merged
merged 3 commits into from
Aug 7, 2022

Conversation

michelle-qinqin
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    docs

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?
    added images for the example of "exclude_current_row"
    improved format for titles of examples in en version
    completed translation of exclude_curent_time in en version

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 4, 2022
Copy link
Collaborator

@lumianph lumianph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doc still needs to be further refined

docs/zh/reference/sql/dql/WINDOW_CLAUSE.md Outdated Show resolved Hide resolved
docs/zh/reference/sql/dql/WINDOW_CLAUSE.md Outdated Show resolved Hide resolved
docs/zh/reference/sql/dql/WINDOW_CLAUSE.md Outdated Show resolved Hide resolved
docs/zh/reference/sql/dql/WINDOW_CLAUSE.md Outdated Show resolved Hide resolved
docs/zh/reference/sql/dql/WINDOW_CLAUSE.md Outdated Show resolved Hide resolved
docs/zh/reference/sql/dql/WINDOW_CLAUSE.md Outdated Show resolved Hide resolved
docs/zh/reference/sql/dql/WINDOW_CLAUSE.md Outdated Show resolved Hide resolved
@lumianph
Copy link
Collaborator

lumianph commented Aug 7, 2022

those comments are not addressed yet? (but marked as resolved?) @michelle-qinqin

@michelle-qinqin
Copy link
Contributor Author

those comments are not addressed yet? (but marked as resolved?) @michelle-qinqin
yes, I closed one comment after I fixed it in local repository, just to avoid missing some comments. I have commit the newest version just now~

@lumianph lumianph merged commit 48a1a52 into 4paradigm:main Aug 7, 2022
@michelle-qinqin michelle-qinqin deleted the exclude_current_row branch August 7, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants