Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-server): add query parameters to the sql query api #2277

Merged
merged 13 commits into from
Sep 15, 2022
Merged

feat(api-server): add query parameters to the sql query api #2277

merged 13 commits into from
Sep 15, 2022

Conversation

qsliu2017
Copy link
Contributor

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 30, 2022
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Base: 75.90% // Head: 75.65% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (4ee7a42) compared to base (6175266).
Patch coverage: 1.63% of modified lines in pull request are covered.

❗ Current head 4ee7a42 differs from pull request most recent head dea9de5. Consider uploading reports for the commit dea9de5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2277      +/-   ##
============================================
- Coverage     75.90%   75.65%   -0.26%     
- Complexity      368      371       +3     
============================================
  Files           629      638       +9     
  Lines        119694   120154     +460     
  Branches       1044     1058      +14     
============================================
+ Hits          90859    90907      +48     
- Misses        28619    29030     +411     
- Partials        216      217       +1     
Impacted Files Coverage Δ
src/apiserver/api_server_impl.cc 0.00% <0.00%> (ø)
src/apiserver/api_server_impl.h 0.00% <ø> (ø)
src/apiserver/api_server_test.cc 0.00% <0.00%> (ø)
src/apiserver/json_helper.h 0.00% <ø> (ø)
src/sdk/sql_cluster_router.h 0.00% <ø> (ø)
src/sdk/sql_router.h 42.85% <ø> (ø)
src/sdk/sql_cluster_router.cc 57.28% <100.00%> (+0.06%) ⬆️
src/sdk/db_sdk.cc 65.69% <0.00%> (-3.14%) ⬇️
src/catalog/tablet_catalog.cc 70.82% <0.00%> (-0.80%) ⬇️
src/cmd/sql_cmd.h 25.00% <0.00%> (-0.37%) ⬇️
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2022

SDK Test Report

  81 files    81 suites   7m 18s ⏱️
168 tests 166 ✔️ 2 💤 0
210 runs  208 ✔️ 2 💤 0

Results for commit dea9de5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2022

Linux Test Report

       55 files       203 suites   1h 5m 28s ⏱️
  9 904 tests   9 897 ✔️ 7 💤 0
14 580 runs  14 573 ✔️ 7 💤 0

Results for commit dea9de5.

♻️ This comment has been updated with latest results.

@aceforeverd
Copy link
Collaborator

ospp - Golang SDK

@github-actions github-actions bot added api-server and removed storage-engine openmldb storage engine. nameserver & tablet labels Aug 16, 2022
src/apiserver/api_server_impl.cc Outdated Show resolved Hide resolved
src/apiserver/api_server_impl.cc Outdated Show resolved Hide resolved
src/apiserver/api_server_impl.cc Outdated Show resolved Hide resolved
src/apiserver/api_server_impl.cc Outdated Show resolved Hide resolved
@qsliu2017 qsliu2017 marked this pull request as ready for review August 28, 2022 12:04
@qsliu2017 qsliu2017 requested a review from aceforeverd August 28, 2022 15:05
src/apiserver/json_helper.cc Outdated Show resolved Hide resolved
src/apiserver/json_helper.cc Outdated Show resolved Hide resolved
src/apiserver/json_helper.cc Outdated Show resolved Hide resolved
src/apiserver/json_helper.cc Outdated Show resolved Hide resolved
@aceforeverd aceforeverd requested a review from dl239 September 1, 2022 15:15
@qsliu2017 qsliu2017 requested review from aceforeverd and removed request for dl239 and vagetablechicken September 5, 2022 04:02
src/apiserver/json_helper.cc Outdated Show resolved Hide resolved
src/apiserver/json_helper.cc Outdated Show resolved Hide resolved
src/apiserver/json_helper.cc Outdated Show resolved Hide resolved
src/apiserver/json_helper.cc Outdated Show resolved Hide resolved
@qsliu2017 qsliu2017 requested review from vagetablechicken and aceforeverd and removed request for aceforeverd and vagetablechicken September 7, 2022 08:32
src/apiserver/api_server_test.cc Outdated Show resolved Hide resolved
Copy link
Collaborator

@vagetablechicken vagetablechicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add doc about it. docs/zh/quickstart/rest_api.md

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 11, 2022
@qsliu2017 qsliu2017 requested review from aceforeverd and vagetablechicken and removed request for aceforeverd September 13, 2022 11:43
@qsliu2017 qsliu2017 requested review from aceforeverd and removed request for vagetablechicken September 15, 2022 06:18
Copy link
Collaborator

@aceforeverd aceforeverd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit d6c7fa7 into 4paradigm:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-server documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(api-server): add query parameters to the sql query api
4 participants