Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(long window): support *_where in sql engine #2255

Merged
merged 40 commits into from
Aug 10, 2022

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Jul 27, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

five op supported:

  • count_where
  • sum_where
  • avg_where
  • min_where
  • max_where

close #1296

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #2255 (2555d63) into main (3a15c04) will increase coverage by 0.10%.
The diff coverage is 85.05%.

@@             Coverage Diff              @@
##               main    #2255      +/-   ##
============================================
+ Coverage     75.75%   75.86%   +0.10%     
  Complexity      368      368              
============================================
  Files           627      629       +2     
  Lines        118520   119225     +705     
  Branches       1022     1022              
============================================
+ Hits          89785    90445     +660     
- Misses        28519    28564      +45     
  Partials        216      216              
Impacted Files Coverage Δ
...ybridse/examples/toydb/src/tablet/tablet_catalog.h 63.15% <0.00%> (ø)
hybridse/include/vm/simple_catalog.h 80.00% <ø> (ø)
...bridse/src/passes/physical/long_window_optimized.h 100.00% <ø> (ø)
src/base/ddl_parser.cc 74.78% <0.00%> (ø)
src/storage/aggregator.h 100.00% <ø> (ø)
hybridse/src/vm/internal/eval.cc 45.11% <45.11%> (ø)
hybridse/include/vm/catalog.h 47.20% <66.66%> (+0.42%) ⬆️
hybridse/src/vm/schemas_context.cc 89.68% <66.66%> (+4.24%) ⬆️
...ridse/src/passes/physical/long_window_optimized.cc 74.64% <71.18%> (-4.50%) ⬇️
src/storage/aggregator.cc 77.79% <73.80%> (+1.44%) ⬆️
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

SDK Test Report

  79 files    79 suites   7m 6s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit 2555d63.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

HybridSE Linux Test Report

19 290 tests   19 288 ✔️  5m 44s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit 2555d63.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

HybridSE Mac Test Report

19 290 tests   19 288 ✔️  7m 40s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit 2555d63.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

Linux Test Report

       55 files       200 suites   54m 10s ⏱️
  9 274 tests   9 267 ✔️ 7 💤 0
13 635 runs  13 628 ✔️ 7 💤 0

Results for commit 2555d63.

♻️ This comment has been updated with latest results.

src/cmd/sql_cmd_test.cc Outdated Show resolved Hide resolved
src/cmd/sql_cmd_test.cc Show resolved Hide resolved
@zhanghaohit
Copy link
Collaborator

Did u verify for those no-filter test (e..g, DeployLongWindowsExecuteCount) if the long window opt is really taking effect rather than reverting back to normal cases?

@aceforeverd
Copy link
Collaborator Author

@lumianph lumianph added this to the v0.6 milestone Aug 8, 2022
@aceforeverd aceforeverd requested a review from zhanghaohit August 9, 2022 13:07
@aceforeverd aceforeverd changed the title feat(long window): support count_where in sql engine feat(long window): support *_where in sql engine Aug 9, 2022
src/cmd/sql_cmd_test.cc Outdated Show resolved Hide resolved
add a case for out of order agg rows
@zhanghaohit zhanghaohit self-requested a review August 9, 2022 23:52
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 8fd84c0 into 4paradigm:main Aug 10, 2022
@aceforeverd aceforeverd deleted the feat-count-where branch August 10, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support long time window with filters
4 participants