-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(long window): support *_where in sql engine #2255
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2255 +/- ##
============================================
+ Coverage 75.75% 75.86% +0.10%
Complexity 368 368
============================================
Files 627 629 +2
Lines 118520 119225 +705
Branches 1022 1022
============================================
+ Hits 89785 90445 +660
- Misses 28519 28564 +45
Partials 216 216
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Did u verify for those no-filter test (e..g, |
rm a skiped test
add a case for out of order agg rows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
five op supported:
close #1296
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?