Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create index core dump #2253

Merged
merged 3 commits into from
Jul 28, 2022
Merged

fix: create index core dump #2253

merged 3 commits into from
Jul 28, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jul 27, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@dl239 dl239 linked an issue Jul 27, 2022 that may be closed by this pull request
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #2253 (1294757) into main (165034f) will increase coverage by 0.00%.
The diff coverage is 86.04%.

@@            Coverage Diff            @@
##               main    #2253   +/-   ##
=========================================
  Coverage     75.79%   75.80%           
  Complexity      354      354           
=========================================
  Files           619      619           
  Lines        117583   117553   -30     
  Branches       1039     1039           
=========================================
- Hits          89126    89108   -18     
+ Misses        28246    28234   -12     
  Partials        211      211           
Impacted Files Coverage Δ
src/catalog/sdk_catalog.h 48.27% <ø> (ø)
src/catalog/tablet_catalog.h 57.81% <ø> (-0.65%) ⬇️
src/schema/index_util.cc 75.75% <ø> (-0.25%) ⬇️
src/catalog/tablet_catalog.cc 70.82% <85.29%> (+0.04%) ⬆️
src/catalog/sdk_catalog.cc 76.34% <88.88%> (+2.34%) ⬆️
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
src/rpc/rpc_client.h 85.13% <0.00%> (-4.06%) ⬇️
src/replica/replicate_node.cc 74.30% <0.00%> (-3.92%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-2.65%) ⬇️
src/zk/zk_client.cc 83.11% <0.00%> (-1.56%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165034f...1294757. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

SDK Test Report

  77 files    77 suites   7m 55s ⏱️
165 tests 163 ✔️ 2 💤 0
206 runs  204 ✔️ 2 💤 0

Results for commit 1294757.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2022

Linux Test Report

       55 files       200 suites   52m 25s ⏱️
  9 241 tests   9 237 ✔️ 4 💤 0
13 597 runs  13 593 ✔️ 4 💤 0

Results for commit 1294757.

♻️ This comment has been updated with latest results.

@dl239 dl239 marked this pull request as ready for review July 27, 2022 11:36
@dl239 dl239 merged commit 3d13dea into 4paradigm:main Jul 28, 2022
@dl239 dl239 deleted the fix/add_index_core branch July 28, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREATE INDEX may cause core dump
3 participants