Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create index core dump #2236

Merged
merged 3 commits into from
Jul 27, 2022
Merged

fix: create index core dump #2236

merged 3 commits into from
Jul 27, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jul 25, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@dl239 dl239 linked an issue Jul 25, 2022 that may be closed by this pull request
@github-actions github-actions bot added the execute-engine hybridse sql engine label Jul 25, 2022
@dl239 dl239 requested review from aceforeverd and wuyou10206 July 25, 2022 05:12
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022

SDK Test Report

  77 files    77 suites   8m 7s ⏱️
165 tests 163 ✔️ 2 💤 0
206 runs  204 ✔️ 2 💤 0

Results for commit 86d0fb7.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #2236 (86d0fb7) into main (2ddaca9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2236      +/-   ##
============================================
+ Coverage     75.79%   75.81%   +0.02%     
  Complexity      354      354              
============================================
  Files           619      619              
  Lines        117581   117583       +2     
  Branches       1039     1039              
============================================
+ Hits          89124    89151      +27     
+ Misses        28246    28221      -25     
  Partials        211      211              
Impacted Files Coverage Δ
hybridse/src/planv2/ast_node_converter.cc 94.35% <100.00%> (+<0.01%) ⬆️
hybridse/src/planv2/ast_node_converter_test.cc 95.68% <100.00%> (+<0.01%) ⬆️
src/storage/disk_table_snapshot.cc 56.71% <0.00%> (-4.48%) ⬇️
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
hybridse/src/codec/type_codec.cc 74.88% <0.00%> (-0.92%) ⬇️
src/zk/zk_client.cc 83.37% <0.00%> (-0.26%) ⬇️
src/tablet/tablet_impl.cc 61.33% <0.00%> (-0.05%) ⬇️
src/log/log_reader.cc 79.11% <0.00%> (+2.64%) ⬆️
src/sdk/db_sdk.cc 67.26% <0.00%> (+3.36%) ⬆️
src/replica/replicate_node.cc 78.21% <0.00%> (+3.91%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddaca9...86d0fb7. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022

HybridSE Linux Test Report

19 287 tests   19 285 ✔️  5m 39s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit 86d0fb7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022

HybridSE Mac Test Report

19 287 tests   19 285 ✔️  7m 16s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit 86d0fb7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2022

Linux Test Report

       55 files       200 suites   54m 8s ⏱️
  9 241 tests   9 237 ✔️ 4 💤 0
13 597 runs  13 593 ✔️ 4 💤 0

Results for commit 86d0fb7.

♻️ This comment has been updated with latest results.

@dl239 dl239 linked an issue Jul 26, 2022 that may be closed by this pull request
@dl239 dl239 merged commit 165034f into 4paradigm:main Jul 27, 2022
@dl239 dl239 deleted the fix/create_index branch July 27, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI core dump if not set option in CREATE INDEX statement create index should avoid coredump
3 participants