Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create with zero partitionnum #2220

Merged
merged 8 commits into from
Sep 1, 2022
Merged

fix: create with zero partitionnum #2220

merged 8 commits into from
Sep 1, 2022

Conversation

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 22, 2022
@dl239 dl239 marked this pull request as ready for review July 22, 2022 03:13
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Base: 75.88% // Head: 75.91% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (01a6785) compared to base (6f24627).
Patch coverage: 55.67% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2220      +/-   ##
============================================
+ Coverage     75.88%   75.91%   +0.03%     
  Complexity      368      368              
============================================
  Files           629      629              
  Lines        119703   119694       -9     
  Branches       1044     1044              
============================================
+ Hits          90832    90862      +30     
+ Misses        28655    28616      -39     
  Partials        216      216              
Impacted Files Coverage Δ
hybridse/include/node/node_manager.h 100.00% <ø> (ø)
src/storage/mem_table_snapshot.cc 63.46% <0.00%> (ø)
src/sdk/node_adapter.cc 48.46% <22.64%> (-2.07%) ⬇️
hybridse/include/node/sql_node.h 83.50% <100.00%> (ø)
hybridse/src/node/node_manager.cc 89.28% <100.00%> (ø)
hybridse/src/node/sql_node.cc 80.11% <100.00%> (ø)
hybridse/src/planv2/ast_node_converter.cc 94.46% <100.00%> (+0.02%) ⬆️
hybridse/src/planv2/ast_node_converter_test.cc 95.68% <100.00%> (ø)
hybridse/src/planv2/planner_v2_test.cc 96.06% <100.00%> (ø)
src/cmd/sql_cmd_test.cc 99.00% <100.00%> (+<0.01%) ⬆️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022

SDK Test Report

  79 files    79 suites   6m 18s ⏱️
167 tests 165 ✔️ 2 💤 0
209 runs  207 ✔️ 2 💤 0

Results for commit 01a6785.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2022

Linux Test Report

       55 files       200 suites   1h 4m 51s ⏱️
  9 753 tests   9 746 ✔️ 7 💤 0
14 354 runs  14 347 ✔️ 7 💤 0

Results for commit 01a6785.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added build openmldb compiling and installing execute-engine hybridse sql engine labels Aug 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022

HybridSE Linux Test Report

19 672 tests   19 670 ✔️  6m 23s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit 01a6785.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2022

HybridSE Mac Test Report

19 672 tests   19 670 ✔️  7m 46s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit 01a6785.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd
Copy link
Collaborator

pls fix tests in ast_node_converter_test

@dl239 dl239 merged commit 6175266 into 4paradigm:main Sep 1, 2022
@dl239 dl239 deleted the fix/create branch September 1, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When partitionnum = 0 and distribution is not specified, the creation of the table should fail
4 participants