fix: join brpc server after stop it #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
storage-engine
Codecov Report
@@ Coverage Diff @@
## main #2173 +/- ##
=============================================
+ Coverage 37.09% 75.75% +38.66%
Complexity 353 353
=============================================
Files 143 619 +476
Lines 8557 117271 +108714
Branches 1039 1039
=============================================
+ Hits 3174 88837 +85663
- Misses 5172 28223 +23051
Partials 211 211
Continue to review full report at Codecov.
|
dl239
approved these changes
Jul 15, 2022
auto-merge was automatically disabled
July 15, 2022 06:21
Head branch was pushed to by a user without write access
mangoGoForward
force-pushed
the
fix/join-brpc-server-after-stop
branch
from
152e10d to
46a041b
Compare
Signed-off-by: mango <[email protected]>
mangoGoForward
force-pushed
the
fix/join-brpc-server-after-stop
branch
from
46a041b to
a43226b
Compare
vagetablechicken
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mango [email protected]
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
join brpc server after stop it
fix bug: we should join after stop brpc server #2157
What is the new behavior (if this is a feature change)?
None