Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: suppoprt exclude current_row in long window #2165

Merged

Conversation

aceforeverd
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@aceforeverd aceforeverd requested a review from zhanghaohit July 13, 2022 05:54
@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jul 13, 2022
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #2165 (cf9580f) into main (012db06) will increase coverage by 38.48%.
The diff coverage is 94.44%.

@@              Coverage Diff              @@
##               main    #2165       +/-   ##
=============================================
+ Coverage     37.30%   75.78%   +38.48%     
  Complexity      353      353               
=============================================
  Files           142      618      +476     
  Lines          8508   117216   +108708     
  Branches       1032     1032               
=============================================
+ Hits           3174    88837    +85663     
- Misses         5123    28168    +23045     
  Partials        211      211               
Impacted Files Coverage Δ
hybridse/src/vm/runner.h 92.84% <ø> (ø)
hybridse/src/vm/runner.cc 67.74% <60.00%> (ø)
src/cmd/sql_cmd_test.cc 99.56% <97.67%> (ø)
hybridse/include/vm/physical_op.h 91.84% <100.00%> (ø)
...ridse/src/passes/physical/long_window_optimized.cc 79.14% <100.00%> (ø)
hybridse/src/vm/window_test.cc 99.31% <100.00%> (ø)
src/log/status.cc 57.62% <0.00%> (ø)
hybridse/src/base/texttable.cc 97.14% <0.00%> (ø)
hybridse/src/sdk/base_impl.cc 69.09% <0.00%> (ø)
src/apiserver/api_server_test.cc 0.00% <0.00%> (ø)
... and 472 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54dd3fe...cf9580f. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022

HybridSE Linux Test Report

19 278 tests   19 276 ✔️  5m 24s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit cf9580f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022

HybridSE Mac Test Report

19 278 tests   19 276 ✔️  6m 47s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit cf9580f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022

SDK Test Report

  76 files    76 suites   7m 59s ⏱️
165 tests 163 ✔️ 2 💤 0
206 runs  204 ✔️ 2 💤 0

Results for commit cf9580f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022

Linux Test Report

       55 files       200 suites   51m 48s ⏱️
  9 229 tests   9 225 ✔️ 4 💤 0
13 580 runs  13 576 ✔️ 4 💤 0

Results for commit cf9580f.

♻️ This comment has been updated with latest results.

@lumianph
Copy link
Collaborator

@aceforeverd for the exclude current row, please also remember to revise the docs to include this new syntax

@aceforeverd
Copy link
Collaborator Author

@aceforeverd for the exclude current row, please also remember to revise the docs to include this new syntax

noted

Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken vagetablechicken merged commit ca69287 into 4paradigm:main Jul 15, 2022
@aceforeverd aceforeverd deleted the feat-exclude-current-row-pre-agg branch July 15, 2022 03:16
@aceforeverd
Copy link
Collaborator Author

exclude current row

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants