Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the bug of comparison with different type #2162

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

mangoGoForward
Copy link
Contributor

Signed-off-by: mango [email protected]

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #2162 (f828d22) into main (012db06) will increase coverage by 38.46%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##               main    #2162       +/-   ##
=============================================
+ Coverage     37.30%   75.77%   +38.46%     
  Complexity      353      353               
=============================================
  Files           142      618      +476     
  Lines          8508   117171   +108663     
  Branches       1032     1032               
=============================================
+ Hits           3174    88787    +85613     
- Misses         5123    28173    +23050     
  Partials        211      211               
Impacted Files Coverage Δ
src/apiserver/api_server_test.cc 0.00% <0.00%> (ø)
src/cmd/sql_cmd_test.cc 99.61% <100.00%> (ø)
...bridse/src/udf/default_defs/max_by_category_def.cc 100.00% <0.00%> (ø)
hybridse/src/base/fe_linenoise.cc 0.00% <0.00%> (ø)
hybridse/examples/toydb/src/storage/segment.cc 100.00% <0.00%> (ø)
hybridse/include/vm/router.h 100.00% <0.00%> (ø)
.../src/passes/physical/transform_up_physical_pass.cc 71.73% <0.00%> (ø)
hybridse/src/codegen/context.h 100.00% <0.00%> (ø)
src/base/linenoise.cc 0.00% <0.00%> (ø)
src/base/ringqueue_test.cc 100.00% <0.00%> (ø)
... and 468 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54dd3fe...f828d22. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2022

Linux Test Report

       55 files       200 suites   52m 11s ⏱️
  9 227 tests   9 223 ✔️ 4 💤 0
13 578 runs  13 574 ✔️ 4 💤 0

Results for commit f828d22.

♻️ This comment has been updated with latest results.

@vagetablechicken vagetablechicken enabled auto-merge (squash) July 13, 2022 11:08
@vagetablechicken vagetablechicken merged commit 836c533 into 4paradigm:main Jul 14, 2022
@mangoGoForward mangoGoForward deleted the fix/type-error branch July 14, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: comparison of integer expressions of different signedness in api_server_test
3 participants