Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unsaferowopt create managed slice #2142

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub added this to the v0.6 milestone Jul 11, 2022
@tobegit3hub tobegit3hub self-assigned this Jul 11, 2022
@github-actions github-actions bot added the execute-engine hybridse sql engine label Jul 11, 2022
@tobegit3hub tobegit3hub changed the title Feat/fix unsaferowopt create managed slice fix: fix unsaferowopt create managed slice Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #2142 (a36e32b) into main (a04ae0d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2142      +/-   ##
============================================
- Coverage     75.80%   75.79%   -0.01%     
- Complexity      347      353       +6     
============================================
  Files           617      618       +1     
  Lines        117069   117128      +59     
  Branches       1029     1032       +3     
============================================
+ Hits          88744    88778      +34     
- Misses        28116    28139      +23     
- Partials        209      211       +2     
Impacted Files Coverage Δ
hybridse/src/vm/core_api.cc 16.14% <0.00%> (ø)
hybridse/src/vm/core_api.h 0.00% <ø> (ø)
src/sdk/db_sdk.cc 64.12% <0.00%> (-2.47%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/catalog/tablet_catalog.cc 69.97% <0.00%> (-0.81%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.49% <0.00%> (-0.32%) ⬇️
src/sdk/sql_cluster_router.cc 54.93% <0.00%> (-0.20%) ⬇️
hybridse/src/vm/runner.cc 67.74% <0.00%> (-0.08%) ⬇️
src/codec/codec.h 100.00% <0.00%> (ø)
src/sdk/sql_insert_row.h 40.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2762f9...a36e32b. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022

SDK Test Report

  76 files    76 suites   7m 33s ⏱️
165 tests 163 ✔️ 2 💤 0
206 runs  204 ✔️ 2 💤 0

Results for commit a36e32b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Linux Test Report

       55 files       200 suites   54m 28s ⏱️
  9 227 tests   9 223 ✔️ 4 💤 0
13 578 runs  13 574 ✔️ 4 💤 0

Results for commit a36e32b.

@github-actions
Copy link
Contributor

HybridSE Linux Test Report

19 278 tests   19 276 ✔️  6m 15s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit a36e32b.

@github-actions
Copy link
Contributor

HybridSE Mac Test Report

19 278 tests   19 276 ✔️  7m 34s ⏱️
     237 suites           2 💤
       67 files             0

Results for commit a36e32b.

@tobegit3hub tobegit3hub merged commit 012db06 into 4paradigm:main Jul 12, 2022
@tobegit3hub
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve the memory leak for UnsafeRowOpt
3 participants