Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make error msgs of TaskManager more explicit #2092

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

hezean
Copy link
Contributor

@hezean hezean commented Jul 6, 2022

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 6, 2022
@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #2092 (33d8e5c) into main (b455771) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2092      +/-   ##
============================================
- Coverage     75.70%   75.68%   -0.02%     
  Complexity      347      347              
============================================
  Files           615      615              
  Lines        116901   116901              
  Branches       1015     1015              
============================================
- Hits          88499    88477      -22     
- Misses        28193    28215      +22     
  Partials        209      209              
Impacted Files Coverage Δ
src/client/taskmanager_client.cc 0.00% <0.00%> (ø)
src/sdk/db_sdk.cc 63.45% <0.00%> (-1.13%) ⬇️
src/client/tablet_client.cc 55.14% <0.00%> (-0.45%) ⬇️
src/tablet/tablet_impl.cc 60.04% <0.00%> (-0.25%) ⬇️
src/nameserver/name_server_impl.cc 42.76% <0.00%> (-0.06%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.64% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b455771...33d8e5c. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

SDK Test Report

  75 files    75 suites   6m 9s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 33d8e5c.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

Linux Test Report

       54 files       196 suites   54m 6s ⏱️
  9 008 tests   9 004 ✔️ 4 💤 0
13 259 runs  13 255 ✔️ 4 💤 0

Results for commit 33d8e5c.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 964a9b9 into 4paradigm:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error msgs of taskmanager client
4 participants