Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the explicit keyword for copy-constructor in list_iterator_codec.h #2073

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

Shigm1026
Copy link
Contributor

@Shigm1026 Shigm1026 commented Jul 5, 2022

close #2061

@github-actions github-actions bot added the execute-engine hybridse sql engine label Jul 5, 2022
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #2073 (8197d83) into main (9950035) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2073   +/-   ##
=========================================
  Coverage     75.70%   75.70%           
  Complexity      347      347           
=========================================
  Files           615      615           
  Lines        116901   116901           
  Branches       1015     1015           
=========================================
+ Hits          88498    88499    +1     
+ Misses        28194    28193    -1     
  Partials        209      209           
Impacted Files Coverage Δ
hybridse/include/codec/list_iterator_codec.h 80.85% <ø> (ø)
src/sdk/db_sdk.cc 66.59% <0.00%> (-1.57%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/zk/zk_client.cc 83.11% <0.00%> (-1.04%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.16%) ⬇️
src/nameserver/name_server_impl.cc 42.80% <0.00%> (+0.05%) ⬆️
src/tablet/tablet_impl.cc 60.14% <0.00%> (+0.09%) ⬆️
src/client/tablet_client.cc 55.48% <0.00%> (+0.33%) ⬆️
src/catalog/tablet_catalog.cc 71.58% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9950035...8197d83. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

SDK Test Report

  75 files    75 suites   5m 51s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 8197d83.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

HybridSE Linux Test Report

19 100 tests   19 098 ✔️  5m 30s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit 8197d83.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

HybridSE Mac Test Report

19 100 tests   19 098 ✔️  6m 44s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit 8197d83.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Linux Test Report

       54 files       196 suites   52m 11s ⏱️
  9 008 tests   9 004 ✔️ 4 💤 0
13 259 runs  13 255 ✔️ 4 💤 0

Results for commit 8197d83.

@aceforeverd aceforeverd changed the title remove the explicit keyword for copy-constructor in list_iterator_codec.h fix: remove the explicit keyword for copy-constructor in list_iterator_codec.h Jul 5, 2022
@aceforeverd aceforeverd requested a review from dl239 July 5, 2022 23:55
@dl239 dl239 merged commit e392007 into 4paradigm:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove the explicit keyword for copy-constructor in list_iterator_codec.h
3 participants