Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1944): warning of invalid copy #2055

Merged
merged 1 commit into from
Jul 4, 2022
Merged

fix(#1944): warning of invalid copy #2055

merged 1 commit into from
Jul 4, 2022

Conversation

Xeonacid
Copy link
Contributor

@Xeonacid Xeonacid commented Jul 2, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Expensive copies inside range-based for-loops,
    fix build: fix warning of invalid copy #1944

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 2, 2022
@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #2055 (30aa067) into main (d5a6a1f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2055      +/-   ##
============================================
+ Coverage     75.69%   75.71%   +0.01%     
  Complexity      347      347              
============================================
  Files           615      615              
  Lines        116901   116901              
  Branches       1015     1015              
============================================
+ Hits          88484    88507      +23     
+ Misses        28208    28185      -23     
  Partials        209      209              
Impacted Files Coverage Δ
src/storage/disk_table.h 88.07% <100.00%> (ø)
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
hybridse/src/vm/runner.cc 67.81% <0.00%> (+0.07%) ⬆️
src/nameserver/name_server_impl.cc 42.79% <0.00%> (+0.10%) ⬆️
hybridse/src/udf/udf_library.cc 81.35% <0.00%> (+0.42%) ⬆️
hybridse/include/vm/mem_catalog.h 73.23% <0.00%> (+0.70%) ⬆️
src/zk/zk_client.cc 84.67% <0.00%> (+1.03%) ⬆️
.../query_response_time/deploy_query_response_time.cc 100.00% <0.00%> (+2.89%) ⬆️
...atistics/query_response_time/query_response_time.h 82.60% <0.00%> (+4.34%) ⬆️
...s/query_response_time/deploy_query_response_time.h 100.00% <0.00%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5a6a1f...30aa067. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2022

SDK Test Report

  75 files    75 suites   5m 27s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 30aa067.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2022

Linux Test Report

       54 files       196 suites   52m 18s ⏱️
  9 008 tests   9 004 ✔️ 4 💤 0
13 259 runs  13 255 ✔️ 4 💤 0

Results for commit 30aa067.

@dl239 dl239 merged commit e4afd6c into 4paradigm:main Jul 4, 2022
@Xeonacid Xeonacid deleted the fix-invalid-copy-warning branch July 4, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: fix warning of invalid copy
3 participants