Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove tablereader declaration #2033

Merged
merged 1 commit into from
Jun 25, 2022
Merged

fix: remove tablereader declaration #2033

merged 1 commit into from
Jun 25, 2022

Conversation

mangoGoForward
Copy link
Contributor

Signed-off-by: mango [email protected]

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 24, 2022
@mangoGoForward mangoGoForward changed the title cleanup: remove tablereader declaration fix: remove tablereader declaration Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #2033 (1a2aa23) into main (af0272c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2033   +/-   ##
=========================================
  Coverage     75.57%   75.57%           
  Complexity      347      347           
=========================================
  Files           609      609           
  Lines        116409   116409           
  Branches       1015     1015           
=========================================
+ Hits          87974    87979    +5     
+ Misses        28226    28221    -5     
  Partials        209      209           
Impacted Files Coverage Δ
src/sdk/table_reader_impl.h 0.00% <ø> (ø)
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/catalog/tablet_catalog.cc 70.77% <0.00%> (-0.81%) ⬇️
src/zk/zk_client.cc 83.11% <0.00%> (-0.26%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.16%) ⬇️
hybridse/src/vm/runner.cc 67.73% <0.00%> (-0.04%) ⬇️
src/nameserver/name_server_impl.cc 42.71% <0.00%> (-0.02%) ⬇️
src/tablet/tablet_impl.cc 59.57% <0.00%> (+0.12%) ⬆️
src/sdk/sql_cluster_router.cc 55.04% <0.00%> (+0.12%) ⬆️
src/client/tablet_client.cc 55.65% <0.00%> (+0.33%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af0272c...1a2aa23. Read the comment docs.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   6m 23s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 1a2aa23.

@github-actions
Copy link
Contributor

Linux Test Report

       54 files       196 suites   49m 56s ⏱️
  8 993 tests   8 989 ✔️ 4 💤 0
13 239 runs  13 235 ✔️ 4 💤 0

Results for commit 1a2aa23.

@aceforeverd aceforeverd merged commit c57b14b into 4paradigm:main Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TableReader declaration from src/sdk/table_reader_impl.h
3 participants