Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1586): default value for sum/avg/sum_where/avg_where #2024

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Jun 22, 2022

close #1586

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jun 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2022

SDK Test Report

  75 files    75 suites   5m 54s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 548623f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2022

Linux Test Report

       54 files       196 suites   51m 36s ⏱️
  8 993 tests   8 989 ✔️ 4 💤 0
13 239 runs  13 235 ✔️ 4 💤 0

Results for commit 548623f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2022

HybridSE Linux Test Report

19 091 tests   19 089 ✔️  6m 28s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit 548623f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2022

HybridSE Mac Test Report

19 091 tests   19 089 ✔️  6m 16s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit 548623f.

♻️ This comment has been updated with latest results.

@aceforeverd
Copy link
Collaborator Author

@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #2024 (548623f) into main (af7a307) will increase coverage by 0.00%.
The diff coverage is 97.67%.

@@            Coverage Diff            @@
##               main    #2024   +/-   ##
=========================================
  Coverage     75.56%   75.56%           
  Complexity      347      347           
=========================================
  Files           609      609           
  Lines        116388   116409   +21     
  Branches       1022     1022           
=========================================
+ Hits          87951    87970   +19     
- Misses        28228    28230    +2     
  Partials        209      209           
Impacted Files Coverage Δ
hybridse/src/codegen/udf_ir_builder_test.cc 99.48% <ø> (-0.01%) ⬇️
hybridse/src/udf/default_udf_library.cc 96.69% <96.66%> (+0.15%) ⬆️
hybridse/src/udf/udaf_test.cc 100.00% <100.00%> (ø)
src/rpc/rpc_client.h 85.13% <0.00%> (-5.41%) ⬇️
src/storage/disk_table_snapshot.cc 56.71% <0.00%> (-4.48%) ⬇️
hybridse/src/udf/udf_test.h 88.67% <0.00%> (-3.78%) ⬇️
hybridse/src/codegen/udf_ir_builder.cc 82.62% <0.00%> (-0.31%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/client/tablet_client.cc 55.31% <0.00%> (-0.23%) ⬇️
src/nameserver/name_server_impl.cc 42.79% <0.00%> (-0.03%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7a307...548623f. Read the comment docs.

@aceforeverd aceforeverd merged commit af0272c into 4paradigm:main Jun 23, 2022
@aceforeverd aceforeverd deleted the fix-1586 branch August 10, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default udf sum/sum_where/avg/avg_where should return NULL if no rows in range or all values is NULL
3 participants