Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove PackValue and Convert functions from src/codec/field_codec.h #2015

Merged
merged 7 commits into from
Jun 22, 2022

Conversation

frazie
Copy link
Contributor

@frazie frazie commented Jun 22, 2022

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 22, 2022
src/codec/field_codec.h Outdated Show resolved Hide resolved
@dl239 dl239 requested a review from vagetablechicken June 22, 2022 02:30
@dl239 dl239 changed the title fix: Removed PackValue and Convert functions from src/codec/field_codec.h refactor: remove PackValue and Convert functions from src/codec/field_codec.h Jun 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2022

Linux Test Report

       54 files       193 suites   48m 57s ⏱️
  8 953 tests   8 949 ✔️ 4 💤 0
13 179 runs  13 175 ✔️ 4 💤 0

Results for commit 6857e6e.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #2015 (6857e6e) into main (855bb52) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2015      +/-   ##
============================================
- Coverage     75.61%   75.55%   -0.06%     
  Complexity      347      347              
============================================
  Files           612      609       -3     
  Lines        116943   116390     -553     
  Branches       1022     1022              
============================================
- Hits          88425    87940     -485     
+ Misses        28309    28241      -68     
  Partials        209      209              
Impacted Files Coverage Δ
src/codec/field_codec.h 16.66% <ø> (-28.93%) ⬇️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
hybridse/src/codegen/aggregate_ir_builder.h 95.45% <0.00%> (-4.55%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/sdk/db_sdk.cc 63.45% <0.00%> (-0.90%) ⬇️
hybridse/src/codegen/aggregate_ir_builder.cc 97.05% <0.00%> (-0.15%) ⬇️
src/nameserver/name_server_impl.cc 42.65% <0.00%> (-0.13%) ⬇️
src/tablet/tablet_impl.cc 59.35% <0.00%> (-0.10%) ⬇️
hybridse/src/codegen/fn_let_ir_builder.cc 95.34% <0.00%> (-0.08%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 855bb52...6857e6e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2022

SDK Test Report

  75 files    75 suites   5m 46s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 6857e6e.

♻️ This comment has been updated with latest results.

@dl239 dl239 enabled auto-merge (squash) June 22, 2022 07:55
@dl239 dl239 linked an issue Jun 22, 2022 that may be closed by this pull request
@dl239 dl239 merged commit af7a307 into 4paradigm:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PackValue and Convert functions from src/codec/field_codec.h
3 participants