Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete unused files(4paradigm#1986) #1994

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix: delete unused files(4paradigm#1986) #1994

merged 1 commit into from
Jun 20, 2022

Conversation

fpetrakov
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This change resolves #1986 by deleting unused files

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 17, 2022
@fpetrakov fpetrakov changed the title delete unused files fix: delete unused files(4paradigm#1986) Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #1994 (89daab6) into main (74217a9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1994   +/-   ##
=========================================
  Coverage     75.62%   75.62%           
  Complexity      347      347           
=========================================
  Files           614      612    -2     
  Lines        116995   116945   -50     
  Branches       1022     1022           
=========================================
- Hits          88474    88440   -34     
+ Misses        28312    28296   -16     
  Partials        209      209           
Impacted Files Coverage Δ
src/storage/mem_table_snapshot.cc 63.46% <ø> (ø)
src/rpc/rpc_client.h 85.13% <0.00%> (-4.06%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/zk/zk_client.cc 83.11% <0.00%> (-0.26%) ⬇️
src/client/tablet_client.cc 55.19% <0.00%> (-0.23%) ⬇️
src/tablet/tablet_impl.cc 59.35% <0.00%> (-0.08%) ⬇️
src/nameserver/name_server_impl.cc 42.80% <0.00%> (ø)
hybridse/src/codec/fe_row_codec.cc 78.64% <0.00%> (+0.15%) ⬆️
src/catalog/client_manager.cc 42.49% <0.00%> (+0.28%) ⬆️
src/sdk/db_sdk.cc 63.90% <0.00%> (+0.44%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74217a9...89daab6. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022

SDK Test Report

  75 files    75 suites   8m 33s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 89daab6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022

Linux Test Report

       56 files       195 suites   55m 1s ⏱️
  8 958 tests   8 954 ✔️ 4 💤 0
13 184 runs  13 180 ✔️ 4 💤 0

Results for commit 89daab6.

♻️ This comment has been updated with latest results.

@dl239 dl239 merged commit f1c80b9 into 4paradigm:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete unused files
3 participants