Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup unused including #1976

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

Jaguar16
Copy link
Contributor

Fix #1975

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Code cleanup in src/cmd/sql_cmd.h

As described in #1975

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 16, 2022
@Jaguar16 Jaguar16 force-pushed the cleanup-including branch from 652435f to 33797cb Compare June 16, 2022 17:28
@Jaguar16
Copy link
Contributor Author

Hello, can an authorized person re-run the pr-linter workflow ? Or do you want me to open another PR ?

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1976 (33797cb) into main (06255ca) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1976   +/-   ##
=========================================
  Coverage     75.61%   75.61%           
  Complexity      347      347           
=========================================
  Files           614      614           
  Lines        116987   116987           
  Branches       1022     1022           
=========================================
+ Hits          88461    88465    +4     
+ Misses        28317    28313    -4     
  Partials        209      209           
Impacted Files Coverage Δ
src/cmd/sql_cmd.h 26.71% <ø> (ø)
src/cmd/sql_cmd_test.cc 99.60% <ø> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
src/rpc/rpc_client.h 85.13% <0.00%> (-4.06%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/nameserver/name_server_impl.cc 42.65% <0.00%> (-0.14%) ⬇️
src/tablet/tablet_impl.cc 59.30% <0.00%> (+0.02%) ⬆️
src/client/tablet_client.cc 55.41% <0.00%> (+0.11%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06255ca...33797cb. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2022

Linux Test Report

       57 files       196 suites   49m 54s ⏱️
  8 961 tests   8 957 ✔️ 4 💤 0
13 187 runs  13 183 ✔️ 4 💤 0

Results for commit 33797cb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   7m 0s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 33797cb.

@dl239 dl239 changed the title Cleanup unused including refactor: cleanup unused including Jun 17, 2022
@dl239
Copy link
Collaborator

dl239 commented Jun 17, 2022

Hello, can an authorized person re-run the pr-linter workflow ? Or do you want me to open another PR ?

pr-linter workflow has passed now. thank you

@dl239 dl239 requested a review from vagetablechicken June 17, 2022 03:48
@vagetablechicken vagetablechicken merged commit 64786da into 4paradigm:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup unused including in sql_cmd.h
3 participants