Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize window agg plan for UnsafeRowOpt #1973

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

tobegit3hub
Copy link
Collaborator

  • Increase max file length for scala file
  • Refactor window agg planner for UnsafeRowOpt

@tobegit3hub tobegit3hub self-assigned this Jun 16, 2022
@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1973 (6bd5013) into main (06255ca) will increase coverage by 0.01%.
The diff coverage is 81.81%.

@@             Coverage Diff              @@
##               main    #1973      +/-   ##
============================================
+ Coverage     75.61%   75.62%   +0.01%     
  Complexity      347      347              
============================================
  Files           614      614              
  Lines        116987   116991       +4     
  Branches       1022     1018       -4     
============================================
+ Hits          88461    88478      +17     
+ Misses        28317    28304      -13     
  Partials        209      209              
Impacted Files Coverage Δ
...4paradigm/openmldb/batch/nodes/WindowAggPlan.scala 60.98% <0.00%> (-0.17%) ⬇️
...aradigm/openmldb/batch/window/WindowComputer.scala 81.55% <100.00%> (+0.55%) ⬆️
src/rpc/rpc_client.h 85.13% <0.00%> (-4.06%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/client/tablet_client.cc 54.97% <0.00%> (-0.34%) ⬇️
src/nameserver/name_server_impl.cc 42.78% <0.00%> (-0.02%) ⬇️
src/tablet/tablet_impl.cc 59.54% <0.00%> (+0.26%) ⬆️
src/zk/zk_client.cc 83.37% <0.00%> (+0.51%) ⬆️
src/storage/aggregator.cc 76.53% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06255ca...6bd5013. Read the comment docs.

@github-actions
Copy link
Contributor

SDK Test Report

  75 files    75 suites   6m 13s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 6bd5013.

@github-actions
Copy link
Contributor

Linux Test Report

       57 files       196 suites   49m 32s ⏱️
  8 961 tests   8 957 ✔️ 4 💤 0
13 187 runs  13 183 ✔️ 4 💤 0

Results for commit 6bd5013.

@tobegit3hub tobegit3hub merged commit a44f9e2 into 4paradigm:main Jun 23, 2022
@tobegit3hub
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants