Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1787): wrong result from window open preceding query #1950

Merged
merged 9 commits into from
Jun 14, 2022

Conversation

aceforeverd
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

close #1787

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the execute-engine hybridse sql engine label Jun 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2022

HybridSE Linux Test Report

19 077 tests   19 075 ✔️  6m 1s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit 1c8c55b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2022

HybridSE Mac Test Report

19 077 tests   19 075 ✔️  6m 26s ⏱️
     235 suites           2 💤
       67 files             0

Results for commit 1c8c55b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2022

Linux Test Report

       57 files       196 suites   50m 3s ⏱️
  8 961 tests   8 957 ✔️ 4 💤 0
13 187 runs  13 183 ✔️ 4 💤 0

Results for commit 1c8c55b.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #1950 (1c8c55b) into main (9cd4bff) will increase coverage by 0.00%.
The diff coverage is 98.70%.

@@            Coverage Diff            @@
##               main    #1950   +/-   ##
=========================================
  Coverage     75.62%   75.62%           
  Complexity      347      347           
=========================================
  Files           614      614           
  Lines        116970   116987   +17     
  Branches       1025     1025           
=========================================
+ Hits          88456    88473   +17     
  Misses        28305    28305           
  Partials        209      209           
Impacted Files Coverage Δ
hybridse/include/vm/mem_catalog.h 72.53% <ø> (ø)
hybridse/src/vm/mem_catalog.cc 73.44% <ø> (ø)
hybridse/src/vm/transform_request_mode_test.cc 95.86% <0.00%> (ø)
hybridse/src/vm/transform_test.cc 97.84% <ø> (ø)
hybridse/include/node/sql_node.h 83.39% <100.00%> (+0.09%) ⬆️
hybridse/src/node/node_manager_test.cc 100.00% <100.00%> (ø)
hybridse/src/node/sql_node.cc 79.89% <100.00%> (+0.09%) ⬆️
hybridse/src/node/sql_node_test.cc 99.65% <100.00%> (+<0.01%) ⬆️
hybridse/src/planv2/ast_node_converter.cc 94.34% <100.00%> (ø)
hybridse/src/planv2/planner_v2_test.cc 96.05% <100.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd4bff...1c8c55b. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 11, 2022

SDK Test Report

  75 files    75 suites   6m 39s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 1c8c55b.

♻️ This comment has been updated with latest results.

@aceforeverd
Copy link
Collaborator Author

hybridse/include/node/sql_node.h Outdated Show resolved Hide resolved
hybridse/include/node/sql_node.h Outdated Show resolved Hide resolved
@zhanghaohit zhanghaohit self-requested a review June 14, 2022 04:18
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 8f810d1 into 4paradigm:main Jun 14, 2022
@aceforeverd aceforeverd deleted the fix-1787-open-preceding branch June 14, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window OPEN PRECEDING in frame start border do not take effect
3 participants