Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write table meta file when update ttl #1935

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jun 8, 2022

fix the bug #1904

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 8, 2022
@dl239 dl239 linked an issue Jun 8, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #1935 (2ab0709) into main (bd121c6) will decrease coverage by 0.00%.
The diff coverage is 89.74%.

@@             Coverage Diff              @@
##               main    #1935      +/-   ##
============================================
- Coverage     75.73%   75.73%   -0.01%     
  Complexity      347      347              
============================================
  Files           613      613              
  Lines        117343   117450     +107     
  Branches       1009     1025      +16     
============================================
+ Hits          88868    88948      +80     
- Misses        28266    28293      +27     
  Partials        209      209              
Impacted Files Coverage Δ
src/tablet/tablet_impl.cc 59.70% <54.16%> (+0.47%) ⬆️
src/tablet/tablet_impl_test.cc 99.54% <98.75%> (-0.04%) ⬇️
src/storage/table.cc 70.73% <100.00%> (+0.48%) ⬆️
src/storage/table_test.cc 99.30% <100.00%> (+<0.01%) ⬆️
...in/java/com/_4paradigm/hybridse/sdk/SqlEngine.java 56.06% <0.00%> (-5.61%) ⬇️
src/storage/schema.h 84.55% <0.00%> (-4.88%) ⬇️
src/storage/schema.cc 77.43% <0.00%> (-4.27%) ⬇️
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 61.30% <0.00%> (-0.31%) ⬇️
src/sdk/sql_cluster_router.cc 54.93% <0.00%> (-0.16%) ⬇️
hybridse/src/udf/udf_test.cc 98.06% <0.00%> (-0.13%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd121c6...2ab0709. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

SDK Test Report

  75 files    75 suites   7m 18s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 2ab0709.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Linux Test Report

       57 files       196 suites   1h 0m 6s ⏱️
  8 968 tests   8 964 ✔️ 4 💤 0
13 184 runs  13 180 ✔️ 4 💤 0

Results for commit 2ab0709.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhanghaohit zhanghaohit self-requested a review June 9, 2022 08:28
@dl239 dl239 merged commit 282ce34 into 4paradigm:main Jun 9, 2022
@dl239 dl239 deleted the fix/update_ttl branch June 9, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tablet has not save ttl when updating the ttl of index
3 participants