Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: insert with database #1929

Merged
merged 3 commits into from
Jun 9, 2022
Merged

feat: insert with database #1929

merged 3 commits into from
Jun 9, 2022

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jun 7, 2022

support insert with database
insert into test.t3 values('b',1122);

@dl239 dl239 linked an issue Jun 7, 2022 that may be closed by this pull request
@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1929 (ccaedca) into main (bd121c6) will decrease coverage by 40.89%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1929       +/-   ##
=============================================
- Coverage     75.73%   34.83%   -40.90%     
  Complexity      347      347               
=============================================
  Files           613      133      -480     
  Lines        117343     8126   -109217     
  Branches       1009     1025       +16     
=============================================
- Hits          88868     2831    -86037     
+ Misses        28266     5086    -23180     
  Partials        209      209               
Impacted Files Coverage Δ
...in/java/com/_4paradigm/hybridse/sdk/SqlEngine.java 56.06% <0.00%> (-5.61%) ⬇️
...a/com/_4paradigm/openmldb/batch/SparkPlanner.scala 61.30% <0.00%> (-0.31%) ⬇️
src/cmd/sql_cmd_test.cc
src/sdk/sql_cluster_router.cc
src/storage/iterator.h
src/sdk/sql_insert_row.cc
src/storage/snapshot.h
...src/passes/physical/split_aggregation_optimized.cc
hybridse/src/passes/physical/cluster_optimized.cc
hybridse/src/codec/fe_row_codec_test.cc
... and 472 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd121c6...ccaedca. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

SDK Test Report

  75 files    75 suites   7m 36s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit ccaedca.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

Linux Test Report

       57 files       196 suites   1h 4m 10s ⏱️
  8 969 tests   8 965 ✔️ 4 💤 0
13 185 runs  13 181 ✔️ 4 💤 0

Results for commit ccaedca.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 607f32b into 4paradigm:main Jun 9, 2022
@dl239 dl239 deleted the feat/db_insert branch June 9, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support db in insert statement
3 participants