Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support codespaces #1922

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

nautaa
Copy link
Collaborator

@nautaa nautaa commented Jun 6, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    close Support GitHub Codespaces #1255
    init codespaces develop environment.

codespaces docs: https://docs.github.com/en/codespaces
1654521371263

  • What is the new behavior (if this is a feature change)?

@nautaa nautaa changed the title feat:support codespaces feat: support codespaces Jun 6, 2022
@nautaa nautaa self-assigned this Jun 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

SDK Test Report

  75 files    75 suites   7m 23s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit d53afd9.

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #1922 (d53afd9) into main (1ffa2e4) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1922      +/-   ##
============================================
+ Coverage     75.73%   75.76%   +0.03%     
  Complexity      347      347              
============================================
  Files           613      613              
  Lines        117341   117341              
  Branches       1009     1009              
============================================
+ Hits          88867    88904      +37     
+ Misses        28265    28228      -37     
  Partials        209      209              
Impacted Files Coverage Δ
hybridse/src/udf/default_udf_library.h 50.00% <0.00%> (-50.00%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.33% <0.00%> (-0.63%) ⬇️
src/client/tablet_client.cc 55.36% <0.00%> (-0.18%) ⬇️
hybridse/src/vm/physical_op.cc 79.27% <0.00%> (-0.07%) ⬇️
hybridse/src/vm/runner.cc 67.75% <0.00%> (-0.04%) ⬇️
hybridse/src/udf/udf_library.h 100.00% <0.00%> (ø)
hybridse/include/vm/physical_op.h 91.81% <0.00%> (ø)
hybridse/src/udf/default_udf_library.cc 96.49% <0.00%> (+0.02%) ⬆️
hybridse/src/udf/udf.cc 84.97% <0.00%> (+0.06%) ⬆️
src/nameserver/name_server_impl.cc 42.84% <0.00%> (+0.09%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ffa2e4...d53afd9. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2022

Linux Test Report

       57 files       193 suites   1h 3m 30s ⏱️
  8 676 tests   8 672 ✔️ 4 💤 0
12 747 runs  12 743 ✔️ 4 💤 0

Results for commit d53afd9.

@@ -0,0 +1,3 @@
FROM 4pdosc/hybridsql:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

centos 7 is a bit old.
I think we can just use ubuntu:20.04.

@vagetablechicken
Copy link
Collaborator

vagetablechicken commented Jun 8, 2022

so won't use ubuntu:20.04? plz make a comment @nautaa

@nautaa
Copy link
Collaborator Author

nautaa commented Jun 8, 2022

so won't use ubuntu:20.04? plz make a comment @nautaa

yep, from my test, ubuntu is OK, but I think the development environment should be consistent with our docker image and cicd environment to facilitate the reproduction of some problems? And I am not familiar with the development environment of java, some configuration of the java environment may be required. Maybe someone will improve codespaces environment in the future.

@vagetablechicken
Copy link
Collaborator

OK, we can improve it next time.

@vagetablechicken vagetablechicken merged commit 9a4e999 into 4paradigm:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GitHub Codespaces
4 participants