-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support codespaces #1922
feat: support codespaces #1922
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1922 +/- ##
============================================
+ Coverage 75.73% 75.76% +0.03%
Complexity 347 347
============================================
Files 613 613
Lines 117341 117341
Branches 1009 1009
============================================
+ Hits 88867 88904 +37
+ Misses 28265 28228 -37
Partials 209 209
Continue to review full report at Codecov.
|
@@ -0,0 +1,3 @@ | |||
FROM 4pdosc/hybridsql:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
centos 7 is a bit old.
I think we can just use ubuntu:20.04.
so won't use ubuntu:20.04? plz make a comment @nautaa |
yep, from my test, ubuntu is OK, but I think the development environment should be consistent with our docker image and cicd environment to facilitate the reproduction of some problems? And I am not familiar with the development environment of java, some configuration of the java environment may be required. Maybe someone will improve codespaces environment in the future. |
OK, we can improve it next time. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
close Support GitHub Codespaces #1255
init codespaces develop environment.
codespaces docs: https://docs.github.com/en/codespaces