fix: aggregator cleanup #1919
Merged
fix: aggregator cleanup #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
storage-engine
Codecov Report
@@ Coverage Diff @@
## main #1919 +/- ##
============================================
+ Coverage 75.73% 75.77% +0.04%
Complexity 347 347
============================================
Files 613 613
Lines 117343 117484 +141
Branches 1009 1009
============================================
+ Hits 88868 89023 +155
+ Misses 28266 28252 -14
Partials 209 209
Continue to review full report at Codecov.
|
zhanghaohit
reviewed
Jun 6, 2022
dl239
reviewed
Jun 6, 2022
dl239
reviewed
Jun 6, 2022
dl239
reviewed
Jun 6, 2022
dl239
reviewed
Jun 6, 2022
| return false; | ||
| } | ||
| if (rs->Size() != 1) { | ||
| status->msg = "duplicate records generate with aggr table name: " + tableInfo.name(); |
There was a problem hiding this comment.
move these check code before drop offline table
dl239
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
close Duplicate records in PRE_AGG_META_INFO #1850
close Cleanup pre-aggr table and meta info #1358
unique pre-aggr table name.
What is the new behavior (if this is a feature change)?