Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update brpc to avoid error define bug #1912

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented May 31, 2022

@github-actions github-actions bot added the build openmldb compiling and installing label May 31, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2022

SDK Test Report

  77 files    77 suites   5m 36s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 001d260.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Linux Test Report

       57 files       193 suites   1h 1m 48s ⏱️
  8 676 tests   8 672 ✔️ 4 💤 0
12 747 runs  12 743 ✔️ 4 💤 0

Results for commit 001d260.

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1912 (001d260) into main (1ffa2e4) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1912      +/-   ##
============================================
+ Coverage     75.73%   75.76%   +0.03%     
  Complexity      347      347              
============================================
  Files           613      613              
  Lines        117341   117341              
  Branches       1009     1009              
============================================
+ Hits          88867    88907      +40     
+ Misses        28265    28225      -40     
  Partials        209      209              
Impacted Files Coverage Δ
src/client/tablet_client.cc 55.21% <0.00%> (-0.34%) ⬇️
src/tablet/tablet_impl.cc 59.17% <0.00%> (-0.18%) ⬇️
src/sdk/sql_cluster_router.cc 55.09% <0.00%> (-0.13%) ⬇️
src/nameserver/name_server_impl.cc 42.86% <0.00%> (+0.12%) ⬆️
src/zk/zk_client.cc 84.33% <0.00%> (+0.78%) ⬆️
src/log/log_reader.cc 79.11% <0.00%> (+2.64%) ⬆️
.../query_response_time/deploy_query_response_time.cc 100.00% <0.00%> (+2.89%) ⬆️
src/sdk/db_sdk.cc 65.98% <0.00%> (+3.40%) ⬆️
src/replica/replicate_node.cc 78.21% <0.00%> (+3.91%) ⬆️
...atistics/query_response_time/query_response_time.h 82.60% <0.00%> (+4.34%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cde3e...001d260. Read the comment docs.

@dl239
Copy link
Collaborator

dl239 commented Jun 1, 2022

add link to the pr of brpc

@aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd merged commit 93c16aa into main Jun 1, 2022
@aceforeverd aceforeverd deleted the vagetablechicken-patch-1 branch June 1, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When lang = zh_CN.UTF-8, the Java SDK executes an error
4 participants