Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support predict server update #1902

Merged
merged 5 commits into from
May 31, 2022
Merged

feat: support predict server update #1902

merged 5 commits into from
May 31, 2022

Conversation

vagetablechicken
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the docker openmldb compile image or demo image label May 30, 2022
@aceforeverd aceforeverd mentioned this pull request May 31, 2022
Merged
@aceforeverd
Copy link
Collaborator

help resolve pylint reports https://github.com/4paradigm/OpenMLDB/runs/6663418951?check_suite_focus=true#step:5:132 ?

@aceforeverd
Copy link
Collaborator

@vagetablechicken will this resolve #1797 ?

@vagetablechicken
Copy link
Collaborator Author

@vagetablechicken will this resolve #1797 ?

Nope. It just supports update model

tobegit3hub
tobegit3hub approved these changes May 31, 2022
View reviewed changes
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vagetablechicken
Copy link
Collaborator Author

https://github.com/4paradigm/OpenMLDB/runs/6663418951?check_suite_focus=true#step:5:132

So many, maybe fix later. good-first issue 😄

@vagetablechicken vagetablechicken merged commit 14cde3e into 4paradigm:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aceforeverd aceforeverd aceforeverd approved these changes

@tobegit3hub tobegit3hub tobegit3hub approved these changes

@dl239 dl239 Awaiting requested review from dl239

Assignees

@vagetablechicken vagetablechicken

Labels
docker openmldb compile image or demo image
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vagetablechicken @aceforeverd @tobegit3hub