Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: built-in function: support radians() function #788 #1897

Merged
merged 15 commits into from
May 28, 2022

Conversation

Ivyee17
Copy link
Contributor

@Ivyee17 Ivyee17 commented May 27, 2022

Close #788

@github-actions github-actions bot added the execute-engine hybridse sql engine label May 27, 2022
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #1897 (875f468) into main (555077f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1897      +/-   ##
============================================
+ Coverage     75.69%   75.70%   +0.01%     
  Complexity      347      347              
============================================
  Files           613      613              
  Lines        117018   117030      +12     
  Branches       1024     1024              
============================================
+ Hits          88574    88595      +21     
+ Misses        28235    28226       -9     
  Partials        209      209              
Impacted Files Coverage Δ
hybridse/src/udf/udf.h 100.00% <ø> (ø)
hybridse/src/codegen/udf_ir_builder_test.cc 99.45% <100.00%> (+<0.01%) ⬆️
hybridse/src/udf/default_udf_library.cc 96.43% <100.00%> (+0.01%) ⬆️
hybridse/src/udf/udf.cc 84.77% <100.00%> (+0.04%) ⬆️
src/log/status.h 70.83% <0.00%> (-12.50%) ⬇️
src/replica/replicate_node.cc 74.30% <0.00%> (-3.92%) ⬇️
src/log/log_reader.cc 76.47% <0.00%> (-2.65%) ⬇️
src/catalog/tablet_catalog.cc 73.77% <0.00%> (-0.87%) ⬇️
src/client/tablet_client.cc 55.11% <0.00%> (-0.23%) ⬇️
src/sdk/sql_cluster_router.cc 54.84% <0.00%> (-0.13%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555077f...875f468. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2022

SDK Test Report

  75 files    75 suites   6m 11s ⏱️
163 tests 161 ✔️ 2 💤 0
204 runs  202 ✔️ 2 💤 0

Results for commit 875f468.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2022

HybridSE Linux Test Report

       67 files       235 suites   5m 41s ⏱️
19 060 tests 19 058 ✔️ 2 💤 0

Results for commit 875f468.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2022

HybridSE Mac Test Report

       67 files       235 suites   6m 24s ⏱️
19 060 tests 19 058 ✔️ 2 💤 0

Results for commit 875f468.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2022

Linux Test Report

       57 files       187 suites   1h 2m 45s ⏱️
  8 503 tests   8 499 ✔️ 4 💤 0
12 489 runs  12 485 ✔️ 4 💤 0

Results for commit 875f468.

♻️ This comment has been updated with latest results.

hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/udf.cc Outdated Show resolved Hide resolved
@aceforeverd aceforeverd requested review from nautaa and zhanghaohit May 27, 2022 09:28
@aceforeverd aceforeverd added udf good first issue Good for newcomers labels May 27, 2022
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/default_udf_library.cc Outdated Show resolved Hide resolved
hybridse/src/udf/udf.cc Outdated Show resolved Hide resolved
hybridse/src/udf/udf.cc Outdated Show resolved Hide resolved
@zhanghaohit
Copy link
Collaborator

Hi @Ivyee17 you can view all the lint warning under the Files changed

@Ivyee17
Copy link
Contributor Author

Ivyee17 commented May 28, 2022

Thanks to all comments. It's now ready to be checked.

Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 57b5308 into 4paradigm:main May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine good first issue Good for newcomers udf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

built-in function: Support RADIANS() function
3 participants