Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace RtidbSchema keywords to PBSchema #1867

Merged
merged 1 commit into from
May 23, 2022
Merged

fix: replace RtidbSchema keywords to PBSchema #1867

merged 1 commit into from
May 23, 2022

Conversation

mangoGoForward
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Fix Rename RtidbSchema to PBSchema #1866

  • What is the new behavior (if this is a feature change)?
    Use PBSchema instead of RtidbSchema

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label May 23, 2022
@aceforeverd aceforeverd requested review from tobegit3hub and dl239 May 23, 2022 02:58
@aceforeverd aceforeverd added the good first issue Good for newcomers label May 23, 2022
@mangoGoForward
Copy link
Contributor Author

Hi @aceforeverd ,one CI failed, seems network unreachable.
HTTPSConnectionPool(host='pypi.tuna.tsinghua.edu.cn', port=443): Read timed out

@aceforeverd
Copy link
Collaborator

Hi @aceforeverd ,one CI failed, seems network unreachable. HTTPSConnectionPool(host='pypi.tuna.tsinghua.edu.cn', port=443): Read timed out

yes, don't worry, the problem does not relate to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2022

SDK Test Report

  75 files    75 suites   6m 20s ⏱️
176 tests 173 ✔️ 3 💤 0
217 runs  214 ✔️ 3 💤 0

Results for commit b911d74.

♻️ This comment has been updated with latest results.

@dl239 dl239 requested a review from vagetablechicken May 23, 2022 04:18
@github-actions
Copy link
Contributor

Linux Test Report

       57 files       187 suites   1h 13m 29s ⏱️
  8 549 tests   8 541 ✔️ 8 💤 0
12 535 runs  12 527 ✔️ 8 💤 0

Results for commit b911d74.

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1867 (b911d74) into main (4c5540f) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1867      +/-   ##
============================================
- Coverage     73.77%   73.75%   -0.03%     
  Complexity      347      347              
============================================
  Files           615      615              
  Lines        120392   120392              
  Branches       1021     1021              
============================================
- Hits          88820    88795      -25     
- Misses        31363    31388      +25     
  Partials        209      209              
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.h 83.33% <ø> (ø)
src/catalog/sdk_catalog_test.cc 100.00% <100.00%> (ø)
src/sdk/sql_cluster_router.cc 54.97% <100.00%> (-0.30%) ⬇️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/sdk/db_sdk.cc 61.67% <0.00%> (-0.91%) ⬇️
src/log/log_reader.cc 78.52% <0.00%> (-0.59%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5540f...b911d74. Read the comment docs.

@dl239 dl239 merged commit 1a8db9f into 4paradigm:main May 23, 2022
@mangoGoForward mangoGoForward deleted the style/rtidbSchema-keyword-replace branch June 2, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename RtidbSchema to PBSchema
4 participants