Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support count_where(*, condition) #1841

Merged
merged 3 commits into from
May 25, 2022

Conversation

nautaa
Copy link
Collaborator

@nautaa nautaa commented May 19, 2022

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    fix

  • What is the current behavior? (You can also link to an open issue here)
    close support count_where(*, filter_condition) #1827

  • What is the new behavior (if this is a feature change)?

@nautaa nautaa self-assigned this May 19, 2022
@github-actions github-actions bot added the execute-engine hybridse sql engine label May 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022

Linux Test Report

       57 files       186 suites   1h 7m 44s ⏱️
  8 543 tests   8 535 ✔️ 8 💤 0
12 529 runs  12 521 ✔️ 8 💤 0

Results for commit 83df75f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022

SDK Test Report

  75 files    75 suites   7m 25s ⏱️
176 tests 173 ✔️ 3 💤 0
217 runs  214 ✔️ 3 💤 0

Results for commit 83df75f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022

HybridSE Linux Test Report

       67 files       235 suites   6m 14s ⏱️
19 059 tests 19 057 ✔️ 2 💤 0

Results for commit 83df75f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022

HybridSE Mac Test Report

       67 files       235 suites   6m 30s ⏱️
19 059 tests 19 057 ✔️ 2 💤 0

Results for commit 83df75f.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1841 (83df75f) into main (b8ff05e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1841   +/-   ##
=========================================
  Coverage     73.74%   73.75%           
  Complexity      347      347           
=========================================
  Files           614      615    +1     
  Lines        120314   120382   +68     
  Branches       1015     1021    +6     
=========================================
+ Hits          88731    88793   +62     
- Misses        31374    31380    +6     
  Partials        209      209           
Impacted Files Coverage Δ
hybridse/src/udf/default_udf_library.cc 96.57% <100.00%> (ø)
...digm/openmldb/batch/window/WindowAggPlanUtil.scala 61.60% <0.00%> (-0.34%) ⬇️
src/client/tablet_client.cc 49.63% <0.00%> (-0.21%) ⬇️
src/sdk/sql_cluster_router.cc 54.84% <0.00%> (-0.13%) ⬇️
src/tablet/tablet_impl.cc 59.10% <0.00%> (-0.03%) ⬇️
src/sdk/db_sdk.cc 62.13% <0.00%> (ø)
hybridse/src/vm/runner.h 92.84% <0.00%> (ø)
...com/_4paradigm/openmldb/batchjob/RunBatchSql.scala 0.00% <0.00%> (ø)
..._4paradigm/openmldb/batchjob/RunBatchAndShow.scala 0.00% <0.00%> (ø)
...4paradigm/openmldb/batchjob/ImportOnlineData.scala 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523c4eb...83df75f. Read the comment docs.

Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aceforeverd aceforeverd merged commit 50d0699 into 4paradigm:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support count_where(*, filter_condition)
3 participants