-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: thread-safe for RequestAggUnionRunner
#1838
fix: thread-safe for RequestAggUnionRunner
#1838
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1838 +/- ##
============================================
- Coverage 73.74% 73.73% -0.02%
Complexity 347 347
============================================
Files 614 614
Lines 120314 120364 +50
Branches 1015 1015
============================================
+ Hits 88731 88753 +22
- Misses 31374 31402 +28
Partials 209 209
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
close
long window
processing core dump under stress test #1837What is the current behavior? (You can also link to an open issue here)
Currently
aggregator_
is re-used for everyRequestAggUnionRunner::Run
, which is not thread-safe if theClusterJob
is also re-used and run in multiple threads (e.g., stored procedure/deployment request).What is the new behavior (if this is a feature change)?
aggregator
is dynamically created for everyRun