Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused code in SimpleResultSet #1810

Merged
merged 1 commit into from
May 13, 2022

Conversation

IZUMI-Zu
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

    remove unused code in SimpleResultSet

  • What is the current behavior? (You can also link to an open issue here)

    Issue remove unused code in SimpleResultSet #1760

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the sdk openmldb java/python sdk label May 12, 2022
@github-actions
Copy link
Contributor

SDK Test Report

  74 files    74 suites   7m 49s ⏱️
175 tests 172 ✔️ 3 💤 0
216 runs  213 ✔️ 3 💤 0

Results for commit 7fd0bd8.

@github-actions
Copy link
Contributor

Linux Test Report

       57 files       186 suites   1h 6m 51s ⏱️
  8 472 tests   8 464 ✔️ 8 💤 0
12 423 runs  12 415 ✔️ 8 💤 0

Results for commit 7fd0bd8.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1810 (7fd0bd8) into main (56203b9) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1810      +/-   ##
============================================
- Coverage     73.75%   73.73%   -0.02%     
  Complexity      347      347              
============================================
  Files           614      614              
  Lines        120318   120318              
  Branches       1015     1015              
============================================
- Hits          88740    88721      -19     
- Misses        31369    31388      +19     
  Partials        209      209              
Impacted Files Coverage Δ
.../com/_4paradigm/openmldb/jdbc/SimpleResultSet.java 7.35% <ø> (ø)
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/sdk/db_sdk.cc 61.67% <0.00%> (-1.37%) ⬇️
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
src/replica/log_replicator.cc 81.87% <0.00%> (-0.33%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/nameserver/name_server_impl.cc 42.63% <0.00%> (-0.21%) ⬇️
src/client/ns_client.cc 46.80% <0.00%> (-0.15%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56203b9...7fd0bd8. Read the comment docs.

@dl239 dl239 changed the title remove unused code in SimpleResultSet refactor: remove unused code in SimpleResultSet May 12, 2022
@dl239 dl239 requested a review from vagetablechicken May 12, 2022 22:57
@dl239 dl239 linked an issue May 12, 2022 that may be closed by this pull request
@vagetablechicken vagetablechicken merged commit b6f1227 into 4paradigm:main May 13, 2022
@IZUMI-Zu IZUMI-Zu deleted the remove_unused_code branch May 13, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk openmldb java/python sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove unused code in SimpleResultSet
3 participants