Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add assertion in unit test of OpenmldbCatalogService #1803

Merged
merged 2 commits into from
May 31, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented May 11, 2022

@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label May 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

SDK Test Report

  75 files    75 suites   6m 7s ⏱️
176 tests 173 ✔️ 3 💤 0
217 runs  214 ✔️ 3 💤 0

Results for commit a2186cc.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022

Linux Test Report

       57 files       187 suites   1h 6m 14s ⏱️
  8 549 tests   8 541 ✔️ 8 💤 0
12 535 runs  12 527 ✔️ 8 💤 0

Results for commit a2186cc.

♻️ This comment has been updated with latest results.

@tobegit3hub tobegit3hub self-assigned this May 12, 2022
@tobegit3hub
Copy link
Collaborator

@SaumyaBhushan It would be great if you can change the code for my comment.

@SaumyaBhushan
Copy link
Contributor Author

@SaumyaBhushan It would be great if you can change the code for my comment.

Sure @tobegit3hub .

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1803 (a2186cc) into main (3701cc2) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1803      +/-   ##
============================================
- Coverage     73.74%   73.73%   -0.01%     
  Complexity      347      347              
============================================
  Files           614      615       +1     
  Lines        120318   120391      +73     
  Branches       1015     1021       +6     
============================================
+ Hits          88725    88775      +50     
- Misses        31384    31407      +23     
  Partials        209      209              
Impacted Files Coverage Δ
hybridse/include/base/spin_lock.h 66.66% <0.00%> (-33.34%) ⬇️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/rpc/rpc_client.h 89.18% <0.00%> (-1.36%) ⬇️
src/sdk/db_sdk.cc 61.67% <0.00%> (-0.46%) ⬇️
...digm/openmldb/batch/window/WindowAggPlanUtil.scala 61.60% <0.00%> (-0.34%) ⬇️
src/client/tablet_client.cc 49.63% <0.00%> (-0.21%) ⬇️
src/nameserver/name_server_impl.cc 42.63% <0.00%> (-0.13%) ⬇️
hybridse/src/vm/runner.cc 67.81% <0.00%> (-0.05%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3701cc2...a2186cc. Read the comment docs.

@vagetablechicken vagetablechicken changed the title Add assertion in unit test of OpenmldbCatalogService fix add assertion in unit test of OpenmldbCatalogService May 26, 2022
@vagetablechicken vagetablechicken changed the title fix add assertion in unit test of OpenmldbCatalogService fix: add assertion in unit test of OpenmldbCatalogService May 26, 2022
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit 4dd2e43 into 4paradigm:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add assertion in unit test of OpenmldbCatalogService
3 participants