-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add assertion in unit test of OpenmldbCatalogService #1803
Conversation
...-batch/src/test/scala/com/_4paradigm/openmldb/batch/catalog/TestOpenmldbCatalogService.scala
Outdated
Show resolved
Hide resolved
@SaumyaBhushan It would be great if you can change the code for my comment. |
Sure @tobegit3hub . |
Codecov Report
@@ Coverage Diff @@
## main #1803 +/- ##
============================================
- Coverage 73.74% 73.73% -0.01%
Complexity 347 347
============================================
Files 614 615 +1
Lines 120318 120391 +73
Branches 1015 1021 +6
============================================
+ Hits 88725 88775 +50
- Misses 31384 31407 +23
Partials 209 209
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test
What is the current behavior? (You can also link to an open issue here)
Add assertion in unit test of OpenmldbCatalogService #1317
close Add assertion in unit test of OpenmldbCatalogService #1317
What is the new behavior (if this is a feature change)?