Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update row index for UnsafeRowOpt #1773

Merged

Conversation

tobegit3hub
Copy link
Collaborator

@tobegit3hub tobegit3hub self-assigned this May 9, 2022
@github-actions github-actions bot added the execute-engine hybridse sql engine label May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

SDK Test Report

  74 files    74 suites   7m 40s ⏱️
175 tests 172 ✔️ 3 💤 0
216 runs  213 ✔️ 3 💤 0

Results for commit 8cad8e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

Linux Test Report

       57 files       186 suites   1h 7m 46s ⏱️
  8 468 tests   8 460 ✔️ 8 💤 0
12 419 runs  12 411 ✔️ 8 💤 0

Results for commit 8cad8e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

HybridSE Linux Test Report

       67 files       235 suites   5m 54s ⏱️
19 003 tests 19 001 ✔️ 2 💤 0

Results for commit 8cad8e9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

HybridSE Mac Test Report

       67 files       235 suites   6m 49s ⏱️
19 003 tests 19 001 ✔️ 2 💤 0

Results for commit 8cad8e9.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1773 (8cad8e9) into main (361f44d) will increase coverage by 0.00%.
The diff coverage is 60.00%.

@@            Coverage Diff            @@
##               main    #1773   +/-   ##
=========================================
  Coverage     73.64%   73.65%           
  Complexity      347      347           
=========================================
  Files           614      614           
  Lines        120131   120134    +3     
  Branches       1015     1015           
=========================================
+ Hits          88475    88481    +6     
+ Misses        31447    31444    -3     
  Partials        209      209           
Impacted Files Coverage Δ
hybridse/src/codec/type_codec.cc 74.40% <60.00%> (-0.60%) ⬇️
src/catalog/client_manager.cc 42.20% <0.00%> (-0.29%) ⬇️
src/sdk/db_sdk.cc 62.81% <0.00%> (-0.23%) ⬇️
src/client/ns_client.cc 44.62% <0.00%> (-0.15%) ⬇️
src/nameserver/name_server_impl.cc 42.23% <0.00%> (-0.07%) ⬇️
src/client/tablet_client.cc 48.29% <0.00%> (ø)
src/nameserver/standalone_test.cc 100.00% <0.00%> (ø)
src/nameserver/name_server_test.cc 92.29% <0.00%> (ø)
src/tablet/tablet_impl.cc 59.20% <0.00%> (+0.29%) ⬆️
src/zk/dist_lock.cc 83.33% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 361f44d...8cad8e9. Read the comment docs.

@tobegit3hub
Copy link
Collaborator Author

add ut for this case.

@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label May 10, 2022
@tobegit3hub tobegit3hub merged commit d156dc1 into 4paradigm:main May 10, 2022
@tobegit3hub
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine execute-engine hybridse sql engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core when enable UnsafeRowOpt for continuous window over window
3 participants