-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update row index for UnsafeRowOpt #1773
Merged
tobegit3hub
merged 3 commits into
4paradigm:main
from
tobegit3hub:feat/fix_unsaferow_get_string_row_index
May 10, 2022
Merged
feat: update row index for UnsafeRowOpt #1773
tobegit3hub
merged 3 commits into
4paradigm:main
from
tobegit3hub:feat/fix_unsaferow_get_string_row_index
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tobegit3hub
commented
May 9, 2022
- Resolve Core when enable UnsafeRowOpt for continuous window over window #1638 .
Codecov Report
@@ Coverage Diff @@
## main #1773 +/- ##
=========================================
Coverage 73.64% 73.65%
Complexity 347 347
=========================================
Files 614 614
Lines 120131 120134 +3
Branches 1015 1015
=========================================
+ Hits 88475 88481 +6
+ Misses 31447 31444 -3
Partials 209 209
Continue to review full report at Codecov.
|
dl239
approved these changes
May 10, 2022
add ut for this case. |
aceforeverd
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.