-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: memroy leak in zk_client.cc #1660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuxiaobai24
changed the title
fix memroy leak in zk_client.cc
fix: memroy leak in zk_client.cc
Apr 19, 2022
dl239
approved these changes
Apr 19, 2022
aceforeverd
reviewed
Apr 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #1660 +/- ##
============================================
+ Coverage 67.47% 67.57% +0.09%
Complexity 323 323
============================================
Files 607 607
Lines 115942 116386 +444
Branches 1000 1000
============================================
+ Hits 78232 78646 +414
- Misses 37503 37533 +30
Partials 207 207
Continue to review full report at Codecov.
|
aceforeverd
approved these changes
Apr 20, 2022
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix memory leak in zk_client.cc.
What is the current behavior? (You can also link to an open issue here)
It should resolve Memory leak in zk_client.cc #1659
What is the new behavior (if this is a feature change)?