Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memroy leak in zk_client.cc #1660

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

wuxiaobai24
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix memory leak in zk_client.cc.

  • What is the current behavior? (You can also link to an open issue here)
    It should resolve Memory leak in zk_client.cc #1659

  • What is the new behavior (if this is a feature change)?

@wuxiaobai24 wuxiaobai24 changed the title fix memroy leak in zk_client.cc fix: memroy leak in zk_client.cc Apr 19, 2022
@aceforeverd aceforeverd added the bug Something isn't working label Apr 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2022

Linux Test Report

       56 files       183 suites   47m 48s ⏱️
  8 218 tests   8 218 ✔️ 0 💤 0
12 134 runs  12 134 ✔️ 0 💤 0

Results for commit 67abe13.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2022

SDK Test Report

  72 files    72 suites   5m 48s ⏱️
172 tests 169 ✔️ 3 💤 0
212 runs  209 ✔️ 3 💤 0

Results for commit 67abe13.

♻️ This comment has been updated with latest results.

src/zk/zk_client.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1660 (67abe13) into main (7f7607b) will increase coverage by 0.09%.
The diff coverage is 92.35%.

@@             Coverage Diff              @@
##               main    #1660      +/-   ##
============================================
+ Coverage     67.47%   67.57%   +0.09%     
  Complexity      323      323              
============================================
  Files           607      607              
  Lines        115942   116386     +444     
  Branches       1000     1000              
============================================
+ Hits          78232    78646     +414     
- Misses        37503    37533      +30     
  Partials        207      207              
Impacted Files Coverage Δ
src/storage/disk_table.h 87.03% <ø> (+0.79%) ⬆️
src/storage/disk_table.cc 82.17% <76.39%> (-1.63%) ⬇️
src/storage/mem_table.h 92.30% <100.00%> (+1.00%) ⬆️
src/storage/table_iterator_test.cc 100.00% <100.00%> (ø)
src/zk/zk_client.cc 84.07% <100.00%> (+0.25%) ⬆️
src/replica/log_replicator.cc 79.47% <0.00%> (-0.33%) ⬇️
src/tablet/tablet_impl.cc 44.03% <0.00%> (-0.29%) ⬇️
hybridse/src/vm/schemas_context.cc 88.62% <0.00%> (-0.22%) ⬇️
src/client/ns_client.cc 44.47% <0.00%> (-0.15%) ⬇️
src/storage/mem_table.cc 76.94% <0.00%> (-0.14%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ea53c...67abe13. Read the comment docs.

@aceforeverd aceforeverd merged commit 7a392df into 4paradigm:main Apr 20, 2022
@aceforeverd
Copy link
Collaborator

thank you!

@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in zk_client.cc
3 participants