Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update catalog when change role #1655

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Apr 19, 2022

No description provided.

@dl239 dl239 added the bug Something isn't working label Apr 19, 2022
@dl239 dl239 linked an issue Apr 19, 2022 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2022

SDK Test Report

  73 files    73 suites   5m 53s ⏱️
173 tests 170 ✔️ 3 💤 0
213 runs  210 ✔️ 3 💤 0

Results for commit ee28b32.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2022

Linux Test Report

       56 files       185 suites   1h 9m 56s ⏱️
  8 382 tests   8 374 ✔️ 8 💤 0
12 298 runs  12 290 ✔️ 8 💤 0

Results for commit ee28b32.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1655 (ee28b32) into main (c139d6d) will increase coverage by 0.37%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1655      +/-   ##
============================================
+ Coverage     67.42%   67.80%   +0.37%     
  Complexity      323      323              
============================================
  Files           607      608       +1     
  Lines        115890   118530    +2640     
  Branches       1000     1000              
============================================
+ Hits          78141    80366    +2225     
- Misses        37542    37957     +415     
  Partials        207      207              
Impacted Files Coverage Δ
src/tablet/tablet_impl.cc 43.29% <0.00%> (-0.95%) ⬇️
src/tablet/tablet_impl_test.cc 0.00% <0.00%> (ø)
src/storage/disk_table.cc 79.20% <0.00%> (-4.60%) ⬇️
src/zk/zk_client.cc 83.28% <0.00%> (-1.60%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/catalog/tablet_catalog.cc 69.76% <0.00%> (-0.60%) ⬇️
hybridse/src/planv2/planner_v2_test.cc 96.05% <0.00%> (-0.57%) ⬇️
src/cmd/sql_cmd_test.cc 99.54% <0.00%> (-0.46%) ⬇️
src/replica/log_replicator.cc 79.47% <0.00%> (-0.33%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fc54ff...ee28b32. Read the comment docs.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit a763d53 into 4paradigm:main Apr 21, 2022
@dl239 dl239 deleted the fix/add_table branch April 21, 2022 02:39
@dl239 dl239 restored the fix/add_table branch April 21, 2022 03:59
@dl239 dl239 deleted the fix/add_table branch April 21, 2022 08:00
@lumianph lumianph mentioned this pull request May 13, 2022
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not add table to catalog after change role
3 participants