feat: aggregator recovery #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nautaa
commented
Apr 13, 2022
e.g. we need to scan the binlog after 6. |
zhanghaohit
requested changes
Apr 14, 2022
zhanghaohit
reviewed
Apr 14, 2022
Codecov Report
@@ Coverage Diff @@
## main #1622 +/- ##
============================================
+ Coverage 67.82% 73.08% +5.25%
Complexity 323 323
============================================
Files 609 610 +1
Lines 118679 119206 +527
Branches 1000 1000
============================================
+ Hits 80491 87117 +6626
+ Misses 37981 31882 -6099
Partials 207 207
Continue to review full report at Codecov.
|
zhanghaohit
requested changes
Apr 15, 2022
zhanghaohit
reviewed
Apr 18, 2022
zhanghaohit
requested changes
Apr 21, 2022
zhanghaohit
reviewed
Apr 21, 2022
zhanghaohit
reviewed
Apr 21, 2022
|
The reason why we are using binlog to do the recover of agg table, is the out of order issue which updates the already flushed results. Binlog cleaning makes it not easy to do it correct. As the deleted binlog may contains the data of the volatile AggrBuffer. Why not we do it in two steps:
|
nautaa
force-pushed
the
feat/aggregator_recovery
branch
from
1eb6630 to
5a19d4f
Compare
zhanghaohit
requested changes
Apr 21, 2022
zhanghaohit
reviewed
Apr 22, 2022
zhanghaohit
reviewed
Apr 22, 2022
zhanghaohit
requested changes
Apr 22, 2022
zhanghaohit
reviewed
Apr 24, 2022
src/tablet/tablet_impl_test.cc
Outdated
| @@ -181,7 +181,8 @@ void AddDefaultAggregatorBaseSchema(::openmldb::api::TableMeta* table_meta) { | |||
| SchemaCodec::SetColumnDesc(table_meta->add_column_desc(), "col3", openmldb::type::DataType::kInt); | |||
| SchemaCodec::SetColumnDesc(table_meta->add_column_desc(), "col4", openmldb::type::DataType::kDouble); | |||
|
|
|||
| SchemaCodec::SetIndex(table_meta->add_column_key(), "idx", "id", "ts_col", ::openmldb::type::kAbsoluteTime, 0, 0); | |||
| SchemaCodec::SetIndex(table_meta->add_column_key(), "idx1", "id", "ts_col", ::openmldb::type::kAbsoluteTime, 0, 0); | |||
| SchemaCodec::SetIndex(table_meta->add_column_key(), "idx2", "col3", "ts_col", ::openmldb::type::kAbsoluteTime, 0, 0); | |||
… into feat/aggregator_recovery
dl239
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature
close Support fault tolerance for pre-aggregation tables #1338
support aggregator recovery from tablet restart.
recovery binlog offsetstarts from the minimize offset of all keys latest offset.DecodeAggrval.AggrBuffer.recover logic